starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-09-02 08:57:18 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #596] [MERGED] Fix property parsing bug in the cli #632

New Issue
Closed
opened 2025-12-30 01:25:51 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:51 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/596
Author: @stackoverflow
Created: 7/24/2024
Status: ✅ Merged
Merged: 7/25/2024
Merged by: @stackoverflow

Base: main ← Head: fix-cli-properties

📝 Commits (2)

📊 Changes

2 files changed (+14 additions, -4 deletions)

View changed files

📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt (+12 -2)
📝 pkl-commons-cli/src/test/kotlin/org/pkl/commons/cli/BaseCommandTest.kt (+2 -2)

📄 Description

This fixes a bug where a property set as -p foo= would be parsed as "true" instead of "".

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/596 **Author:** [@stackoverflow](https://github.com/stackoverflow) **Created:** 7/24/2024 **Status:** ✅ Merged **Merged:** 7/25/2024 **Merged by:** [@stackoverflow](https://github.com/stackoverflow) **Base:** `main` ← **Head:** `fix-cli-properties` --- ### 📝 Commits (2) - [`0e36213`](https://github.com/apple/pkl/commit/0e362133c410b990f11a44ea4c5080e5d338f244) Fix property parsing bug in the cli - [`1d96150`](https://github.com/apple/pkl/commit/1d9615035b499cdf043d001543dfbb0318ceba57) fix remark ### 📊 Changes **2 files changed** (+14 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt` (+12 -2) 📝 `pkl-commons-cli/src/test/kotlin/org/pkl/commons/cli/BaseCommandTest.kt` (+2 -2) </details> ### 📄 Description This fixes a bug where a property set as `-p foo=` would be parsed as `"true"` instead of `""`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:51 +01:00
adam closed this issue 2025-12-30 01:25:51 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#632