[PR #580] [MERGED] Support _ in String[toInt|toIntOrNull|toFloat|toFloatOrNull] #631

New Issue

adam · 2025-12-30T01:25:50+01:00

adam commented

2025-12-30 01:25:50 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/580
Author: @stackoverflow
Created: 7/16/2024
Status: ✅ Merged
Merged: 7/16/2024
Merged by: @stackoverflow

Base: main ← Head: to-float-accept_

📝 Commits (1)

added20 Support _ in String[toInt|toIntOrNull|toFloat|toFloatOrNull]

📊 Changes

3 files changed (+37 additions, -6 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/stdlib/base/StringNodes.java (+23 -4)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/api/string.pkl (+8 -2)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/string.pcf (+6 -0)

📄 Description

The logic is the same as the Pkl parser

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/580 **Author:** [@stackoverflow](https://github.com/stackoverflow) **Created:** 7/16/2024 **Status:** ✅ Merged **Merged:** 7/16/2024 **Merged by:** [@stackoverflow](https://github.com/stackoverflow) **Base:** `main` ← **Head:** `to-float-accept_` --- ### 📝 Commits (1) - [`added20`](https://github.com/apple/pkl/commit/added2000ddf2dc45846729d4c28ea89790878f9) Support `_` in String[toInt|toIntOrNull|toFloat|toFloatOrNull] ### 📊 Changes **3 files changed** (+37 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/base/StringNodes.java` (+23 -4) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/api/string.pkl` (+8 -2) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/string.pcf` (+6 -0) </details> ### 📄 Description The logic is the same as the Pkl parser --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:25:50 +01:00

adam closed this issue

2025-12-30 01:25:50 +01:00

adam referenced this issue

2025-12-30 01:25:57 +01:00

[PR #631] [MERGED] Fix parsing of external property values containing `=` #651

Sign in to join this conversation.