[PR #560] [MERGED] Add spotless formatting for remaining .kt/.kts files #622

New Issue

adam · 2025-12-30T01:25:43+01:00

adam commented

2025-12-30 01:25:43 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/560
Author: @bioball
Created: 6/29/2024
Status: ✅ Merged
Merged: 7/1/2024
Merged by: @bioball

Base: main ← Head: spotless-kotlin

📝 Commits (3)

b52916f Use spotless to format remaining Kotlin files
816cd48 Run spotless apply
9279785 Add Git ignore-revs file

📊 Changes

131 files changed (+5472 additions, -3543 deletions)

View changed files

➕ .git-blame-ignore-revs (+2 -0)
📝 DEVELOPMENT.adoc (+2 -0)
📝 bench/bench.gradle.kts (+25 -12)
📝 build.gradle.kts (+23 -9)
📝 buildSrc/build.gradle.kts (+18 -17)
📝 buildSrc/settings.gradle.kts (+16 -5)
📝 buildSrc/src/main/kotlin/BuildInfo.kt (+28 -28)
📝 buildSrc/src/main/kotlin/ExecutableJar.kt (+24 -11)
📝 buildSrc/src/main/kotlin/GradlePluginTests.kt (+16 -1)
📝 buildSrc/src/main/kotlin/GradleVersionInfo.kt (+27 -7)
📝 buildSrc/src/main/kotlin/HtmlValidator.kt (+16 -1)
📝 buildSrc/src/main/kotlin/MergeSourcesJars.kt (+26 -11)
📝 buildSrc/src/main/kotlin/ResolveSourcesJars.kt (+31 -14)
📝 buildSrc/src/main/kotlin/pklAllProjects.gradle.kts (+66 -32)
📝 buildSrc/src/main/kotlin/pklFatJar.gradle.kts (+119 -107)
📝 buildSrc/src/main/kotlin/pklGraalVm.gradle.kts (+63 -47)
📝 buildSrc/src/main/kotlin/pklGradlePluginTest.gradle.kts (+31 -26)
📝 buildSrc/src/main/kotlin/pklHtmlValidator.gradle.kts (+48 -33)
📝 buildSrc/src/main/kotlin/pklJavaLibrary.gradle.kts (+32 -11)
📝 buildSrc/src/main/kotlin/pklKotlinLibrary.gradle.kts (+15 -8)

...and 80 more files

📄 Description

This adds formatting for:

Gradle kts files
Test sources
Kotlin files in buildSrc

This can be reviewed in two commits; the first one adds business logic to run spotless, and the second one just runs spotless apply.

Note: for sanity sake, the first commit also includes changes created by running spotlessApply on those files, because it's too hard to separate them out.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/560 **Author:** [@bioball](https://github.com/bioball) **Created:** 6/29/2024 **Status:** ✅ Merged **Merged:** 7/1/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `spotless-kotlin` --- ### 📝 Commits (3) - [`b52916f`](https://github.com/apple/pkl/commit/b52916fdbb951aaf4fe1749ef20c8dd3174c12a5) Use spotless to format remaining Kotlin files - [`816cd48`](https://github.com/apple/pkl/commit/816cd483c8adf4c04e14236c173a1dc6bd2579ea) Run spotless apply - [`9279785`](https://github.com/apple/pkl/commit/927978523856d065951f0f5cef1196a13c77c29c) Add Git ignore-revs file ### 📊 Changes **131 files changed** (+5472 additions, -3543 deletions) <details> <summary>View changed files</summary> ➕ `.git-blame-ignore-revs` (+2 -0) 📝 `DEVELOPMENT.adoc` (+2 -0) 📝 `bench/bench.gradle.kts` (+25 -12) 📝 `build.gradle.kts` (+23 -9) 📝 `buildSrc/build.gradle.kts` (+18 -17) 📝 `buildSrc/settings.gradle.kts` (+16 -5) 📝 `buildSrc/src/main/kotlin/BuildInfo.kt` (+28 -28) 📝 `buildSrc/src/main/kotlin/ExecutableJar.kt` (+24 -11) 📝 `buildSrc/src/main/kotlin/GradlePluginTests.kt` (+16 -1) 📝 `buildSrc/src/main/kotlin/GradleVersionInfo.kt` (+27 -7) 📝 `buildSrc/src/main/kotlin/HtmlValidator.kt` (+16 -1) 📝 `buildSrc/src/main/kotlin/MergeSourcesJars.kt` (+26 -11) 📝 `buildSrc/src/main/kotlin/ResolveSourcesJars.kt` (+31 -14) 📝 `buildSrc/src/main/kotlin/pklAllProjects.gradle.kts` (+66 -32) 📝 `buildSrc/src/main/kotlin/pklFatJar.gradle.kts` (+119 -107) 📝 `buildSrc/src/main/kotlin/pklGraalVm.gradle.kts` (+63 -47) 📝 `buildSrc/src/main/kotlin/pklGradlePluginTest.gradle.kts` (+31 -26) 📝 `buildSrc/src/main/kotlin/pklHtmlValidator.gradle.kts` (+48 -33) 📝 `buildSrc/src/main/kotlin/pklJavaLibrary.gradle.kts` (+32 -11) 📝 `buildSrc/src/main/kotlin/pklKotlinLibrary.gradle.kts` (+15 -8) _...and 80 more files_ </details> ### 📄 Description This adds formatting for: * Gradle kts files * Test sources * Kotlin files in buildSrc This can be reviewed in two commits; the first one adds business logic to run spotless, and the second one just runs spotless apply. Note: for sanity sake, the first commit also includes changes created by running `spotlessApply` on those files, because it's too hard to separate them out. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:25:43 +01:00

adam closed this issue

2025-12-30 01:25:43 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#622