[PR #526] [MERGED] Change CLI flag and Gradle name for proxy options #604

New Issue

adam · 2025-12-30T01:25:36+01:00

adam commented

2025-12-30 01:25:36 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/526
Author: @bioball
Created: 6/13/2024
Status: ✅ Merged
Merged: 6/14/2024
Merged by: @bioball

Base: main ← Head: proxy-flag-rename

📝 Commits (1)

f342614 Change CLI flag and Gradle name for proxy options

📊 Changes

9 files changed (+27 additions, -27 deletions)

View changed files

📝 docs/modules/pkl-cli/pages/index.adoc (+4 -4)
📝 docs/modules/pkl-cli/partials/cli-common-options.adoc (+2 -2)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt (+4 -4)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliBaseOptions.kt (+2 -2)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliCommand.kt (+2 -2)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt (+4 -4)
📝 pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java (+3 -3)
📝 pkl-gradle/src/main/java/org/pkl/gradle/spec/BasePklSpec.java (+2 -2)
📝 pkl-gradle/src/main/java/org/pkl/gradle/task/BasePklTask.java (+4 -4)

📄 Description

Rationale: "proxy" can mean very different things (e.g. Proxy in Java). This makes the flag name more specific.

CLI:

--proxy -> --http-proxy
--no-proxy -> --http-no-proxy

Gradle:

proxyAddress -> httpProxy
noProxy -> httpNoProxy

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/526 **Author:** [@bioball](https://github.com/bioball) **Created:** 6/13/2024 **Status:** ✅ Merged **Merged:** 6/14/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `proxy-flag-rename` --- ### 📝 Commits (1) - [`f342614`](https://github.com/apple/pkl/commit/f3426141e75b089db4d881f6e907a1964cc12712) Change CLI flag and Gradle name for proxy options ### 📊 Changes **9 files changed** (+27 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/pkl-cli/pages/index.adoc` (+4 -4) 📝 `docs/modules/pkl-cli/partials/cli-common-options.adoc` (+2 -2) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt` (+4 -4) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliBaseOptions.kt` (+2 -2) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliCommand.kt` (+2 -2) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt` (+4 -4) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java` (+3 -3) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/spec/BasePklSpec.java` (+2 -2) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/task/BasePklTask.java` (+4 -4) </details> ### 📄 Description Rationale: "proxy" can mean very different things (e.g. [Proxy](https://docs.oracle.com/javase/8/docs/api/java/lang/reflect/Proxy.html) in Java). This makes the flag name more specific. CLI: * `--proxy` -> `--http-proxy` * `--no-proxy` -> `--http-no-proxy` Gradle: * `proxyAddress` -> `httpProxy` * `noProxy` -> `httpNoProxy` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:25:36 +01:00

adam closed this issue

2025-12-30 01:25:37 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#604