starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #524] Fix links to dependencies #602

New Issue
Open
opened 2025-12-30 01:25:36 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:36 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/524
Author: @bioball
Created: 6/13/2024
Status: 🔄 Open

Base: main ← Head: dependency-link-fix

📝 Commits (1)

  • 2538752 Fix links to dependencies

📊 Changes

17 files changed (+44 additions, -30 deletions)

View changed files

📝 pkl-commons-test/src/main/files/packages/birds@0.5.0/birds@0.5.0.json (+1 -1)
📝 pkl-commons-test/src/main/files/packages/fruit@1.0.5/fruit@1.0.5.json (+0 -1)
📝 pkl-commons-test/src/main/files/packages/fruit@1.1.0/fruit@1.1.0.json (+0 -1)
📝 pkl-commons-test/src/main/kotlin/org/pkl/commons/test/PackageServer.kt (+3 -3)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/packages/packages1.pkl (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/packages/packages2.pkl (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/projects/project4/PklProject.deps.json (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/packages/packages2.pcf (+2 -2)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/CliDocGenerator.kt (+3 -2)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/DocPackageInfo.kt (+1 -1)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/DocScope.kt (+1 -1)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/PageGenerator.kt (+24 -9)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/index.html (+1 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/birds/0.5.0/Bird/index.html (+1 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/birds/0.5.0/index.html (+2 -2)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/birds/0.5.0/package-data.json (+1 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/fruit/1.1.0/index.html (+1 -1)

📄 Description

This fixes an issue where package dependencies are not rendered correctly.

This also changes the names shown for these dependencies.

Before: fruits
After: localhost:0/fruits

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/524 **Author:** [@bioball](https://github.com/bioball) **Created:** 6/13/2024 **Status:** 🔄 Open **Base:** `main` ← **Head:** `dependency-link-fix` --- ### 📝 Commits (1) - [`2538752`](https://github.com/apple/pkl/commit/2538752d04ac1f6e11cd22d53b684aede5adf7db) Fix links to dependencies ### 📊 Changes **17 files changed** (+44 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `pkl-commons-test/src/main/files/packages/birds@0.5.0/birds@0.5.0.json` (+1 -1) 📝 `pkl-commons-test/src/main/files/packages/fruit@1.0.5/fruit@1.0.5.json` (+0 -1) 📝 `pkl-commons-test/src/main/files/packages/fruit@1.1.0/fruit@1.1.0.json` (+0 -1) 📝 `pkl-commons-test/src/main/kotlin/org/pkl/commons/test/PackageServer.kt` (+3 -3) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/packages/packages1.pkl` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/packages/packages2.pkl` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/projects/project4/PklProject.deps.json` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/packages/packages2.pcf` (+2 -2) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/CliDocGenerator.kt` (+3 -2) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/DocPackageInfo.kt` (+1 -1) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/DocScope.kt` (+1 -1) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/PageGenerator.kt` (+24 -9) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/index.html` (+1 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/birds/0.5.0/Bird/index.html` (+1 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/birds/0.5.0/index.html` (+2 -2) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/birds/0.5.0/package-data.json` (+1 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/fruit/1.1.0/index.html` (+1 -1) </details> ### 📄 Description This fixes an issue where package dependencies are not rendered correctly. This also changes the names shown for these dependencies. Before: `fruits` After: `localhost:0/fruits` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#602
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?