starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-09-01 08:27:19 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #503] [MERGED] Omit showing stdlib as dependency in pkldoc #587

New Issue
Closed
opened 2025-12-30 01:25:30 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:30 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/503
Author: @bioball
Created: 5/23/2024
Status: ✅ Merged
Merged: 5/28/2024
Merged by: @bioball

Base: main ← Head: omit-stdlib-dependency

📝 Commits (1)

  • e2510e5 Omit showing stdlib as dependency in pkldoc

📊 Changes

6 files changed (+11 additions, -8 deletions)

View changed files

📝 pkl-doc/src/main/kotlin/org/pkl/doc/PageGenerator.kt (+4 -2)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/RuntimeDataGenerator.kt (+5 -0)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/index.html (+1 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/com.package2/4.5.6/index.html (+0 -2)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/birds/0.5.0/index.html (+1 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/fruit/1.1.0/index.html (+0 -2)

📄 Description

The stdlib is an implicit dependency for every package. Showing this as a dependency is unnecessary noise.

Before:
Screenshot 2024-05-22 at 4 43 05 PM

After:
Screenshot 2024-05-22 at 4 42 43 PM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/503 **Author:** [@bioball](https://github.com/bioball) **Created:** 5/23/2024 **Status:** ✅ Merged **Merged:** 5/28/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `omit-stdlib-dependency` --- ### 📝 Commits (1) - [`e2510e5`](https://github.com/apple/pkl/commit/e2510e54d8929e27fad57402253198f25b22f4a6) Omit showing stdlib as dependency in pkldoc ### 📊 Changes **6 files changed** (+11 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/PageGenerator.kt` (+4 -2) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/RuntimeDataGenerator.kt` (+5 -0) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/index.html` (+1 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/com.package2/4.5.6/index.html` (+0 -2) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/birds/0.5.0/index.html` (+1 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/fruit/1.1.0/index.html` (+0 -2) </details> ### 📄 Description The stdlib is an implicit dependency for every package. Showing this as a dependency is unnecessary noise. Before: ![Screenshot 2024-05-22 at 4 43 05 PM](https://github.com/apple/pkl/assets/4590460/e8d7eba2-29c0-4de8-a9f6-97c5b7dcf5d5) After: ![Screenshot 2024-05-22 at 4 42 43 PM](https://github.com/apple/pkl/assets/4590460/fba81fc0-3112-4106-a9a9-d435de2d783f) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:30 +01:00
adam closed this issue 2025-12-30 01:25:30 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#587