starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #499] [MERGED] Implemented package mapping for Java/Kotlin code generation #586

New Issue
Closed
opened 2025-12-30 01:25:29 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:29 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/499
Author: @netvl
Created: 5/17/2024
Status: ✅ Merged
Merged: 6/13/2024
Merged by: @bioball

Base: main ← Head: package-mappings

📝 Commits (10+)

  • 9f0afbd Implemented package mapping for Java code generation
  • 3fd714a Fixed CLI options parsing for java codegen
  • 86bb912 Added path filtering to Java codegen
  • da06219 Implemented support for package mappings in Kotlin codegen
  • ffe8aba Added support for package mappings in the Gradle plugin
  • da1ab23 Updated documentation for CLI and Gradle plugins
  • e211a49 Fixes per review
  • 518e9c1 Implemented full class renaming
  • efdb28d Fixes per review
  • 3d7e411 Adjust docs and add tests for NameMapper, miscellaneous polish

📊 Changes

25 files changed (+1096 additions, -154 deletions)

View changed files

📝 docs/modules/java-binding/pages/codegen.adoc (+0 -7)
📝 docs/modules/java-binding/partials/cli-codegen-options.adoc (+54 -0)
📝 docs/modules/pkl-gradle/partials/gradle-codegen-properties.adoc (+50 -0)
📝 pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/CliJavaCodeGeneratorOptions.kt (+12 -2)
📝 pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/JavaCodeGenerator.kt (+28 -26)
📝 pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/Main.kt (+18 -1)
📝 pkl-codegen-java/src/test/kotlin/org/pkl/codegen/java/CliJavaCodeGeneratorTest.kt (+109 -0)
📝 pkl-codegen-java/src/test/kotlin/org/pkl/codegen/java/InMemoryJavaCompiler.kt (+3 -1)
📝 pkl-codegen-java/src/test/kotlin/org/pkl/codegen/java/JavaCodeGeneratorTest.kt (+237 -20)
📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorOptions.kt (+17 -2)
📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/KotlinCodeGenerator.kt (+25 -23)
📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/Main.kt (+18 -1)
📝 pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorTest.kt (+113 -0)
📝 pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/InMemoryKotlinCompiler.kt (+1 -0)
📝 pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/KotlinCodeGeneratorTest.kt (+245 -31)
➕ pkl-commons/src/main/kotlin/org/pkl/commons/NameMapper.kt (+73 -0)
➕ pkl-commons/src/test/kotlin/org/pkl/commons/NameMapperTest.kt (+59 -0)
📝 pkl-gradle/pkl-gradle.gradle.kts (+5 -1)
📝 pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java (+1 -0)
📝 pkl-gradle/src/main/java/org/pkl/gradle/spec/CodeGenSpec.java (+3 -0)

...and 5 more files

📄 Description

See #456 for motivation.

  • Implement package mapping in Java codegen, add tests
  • Implement package mapping in Kotlin codegen, add tests
  • Propagate configuration to the Gradle plugin

Closes #456

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/499 **Author:** [@netvl](https://github.com/netvl) **Created:** 5/17/2024 **Status:** ✅ Merged **Merged:** 6/13/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `package-mappings` --- ### 📝 Commits (10+) - [`9f0afbd`](https://github.com/apple/pkl/commit/9f0afbd9bf55c34f5a2b1274e9a576cde5551ea7) Implemented package mapping for Java code generation - [`3fd714a`](https://github.com/apple/pkl/commit/3fd714ab4a083f5beb91318995fa83d11e556aa1) Fixed CLI options parsing for java codegen - [`86bb912`](https://github.com/apple/pkl/commit/86bb91230740696d297295bf25f807e742d3e132) Added path filtering to Java codegen - [`da06219`](https://github.com/apple/pkl/commit/da06219e900878860e02f487cd077060d5924c75) Implemented support for package mappings in Kotlin codegen - [`ffe8aba`](https://github.com/apple/pkl/commit/ffe8aba053055244d1709edf06098aac2ff31b06) Added support for package mappings in the Gradle plugin - [`da1ab23`](https://github.com/apple/pkl/commit/da1ab2305cff0b24ad5155e189848ec9d74a8f4b) Updated documentation for CLI and Gradle plugins - [`e211a49`](https://github.com/apple/pkl/commit/e211a493fbb40f3614861f3ce9859b23eeb69abb) Fixes per review - [`518e9c1`](https://github.com/apple/pkl/commit/518e9c164b2cf36f3b7c6cf7347703cae9f09e32) Implemented full class renaming - [`efdb28d`](https://github.com/apple/pkl/commit/efdb28d7cd347b0cdaad34aa48a8b1dfcac016af) Fixes per review - [`3d7e411`](https://github.com/apple/pkl/commit/3d7e4116b6fc17a525e1ddffa5b1b4b327d69088) Adjust docs and add tests for NameMapper, miscellaneous polish ### 📊 Changes **25 files changed** (+1096 additions, -154 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/java-binding/pages/codegen.adoc` (+0 -7) 📝 `docs/modules/java-binding/partials/cli-codegen-options.adoc` (+54 -0) 📝 `docs/modules/pkl-gradle/partials/gradle-codegen-properties.adoc` (+50 -0) 📝 `pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/CliJavaCodeGeneratorOptions.kt` (+12 -2) 📝 `pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/JavaCodeGenerator.kt` (+28 -26) 📝 `pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/Main.kt` (+18 -1) 📝 `pkl-codegen-java/src/test/kotlin/org/pkl/codegen/java/CliJavaCodeGeneratorTest.kt` (+109 -0) 📝 `pkl-codegen-java/src/test/kotlin/org/pkl/codegen/java/InMemoryJavaCompiler.kt` (+3 -1) 📝 `pkl-codegen-java/src/test/kotlin/org/pkl/codegen/java/JavaCodeGeneratorTest.kt` (+237 -20) 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorOptions.kt` (+17 -2) 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/KotlinCodeGenerator.kt` (+25 -23) 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/Main.kt` (+18 -1) 📝 `pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorTest.kt` (+113 -0) 📝 `pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/InMemoryKotlinCompiler.kt` (+1 -0) 📝 `pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/KotlinCodeGeneratorTest.kt` (+245 -31) ➕ `pkl-commons/src/main/kotlin/org/pkl/commons/NameMapper.kt` (+73 -0) ➕ `pkl-commons/src/test/kotlin/org/pkl/commons/NameMapperTest.kt` (+59 -0) 📝 `pkl-gradle/pkl-gradle.gradle.kts` (+5 -1) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java` (+1 -0) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/spec/CodeGenSpec.java` (+3 -0) _...and 5 more files_ </details> ### 📄 Description See #456 for motivation. - [x] Implement package mapping in Java codegen, add tests - [x] Implement package mapping in Kotlin codegen, add tests - [x] Propagate configuration to the Gradle plugin Closes #456 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:29 +01:00
adam closed this issue 2025-12-30 01:25:30 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#586
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?