[PR #496] [MERGED] Fix local dependency globbing #584

Closed
opened 2025-12-30 01:25:29 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/496
Author: @bioball
Created: 5/15/2024
Status: Merged
Merged: 5/16/2024
Merged by: @bioball

Base: mainHead: local-dependency-globbing-fix


📝 Commits (1)

  • 214bd55 Fix local dependency globbing

📊 Changes

2 files changed (+20 additions, -4 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/module/ModuleKeys.java (+10 -3)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/projects/project1/globbing.pcf (+10 -1)

📄 Description

This fixes an issue where globbing resources within a local dependency fails to match anything.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/496 **Author:** [@bioball](https://github.com/bioball) **Created:** 5/15/2024 **Status:** ✅ Merged **Merged:** 5/16/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `local-dependency-globbing-fix` --- ### 📝 Commits (1) - [`214bd55`](https://github.com/apple/pkl/commit/214bd554404b230691a5e464835ef9004ef7843d) Fix local dependency globbing ### 📊 Changes **2 files changed** (+20 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/module/ModuleKeys.java` (+10 -3) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/projects/project1/globbing.pcf` (+10 -1) </details> ### 📄 Description This fixes an issue where globbing resources within a local dependency fails to match anything. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:29 +01:00
adam closed this issue 2025-12-30 01:25:29 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#584