[PR #489] [MERGED] Encode filepaths to be safe for Windows #581

New Issue

2025-12-30T01:25:27+01:00

adam commented

2025-12-30 01:25:27 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/489
Author: @bioball
Created: 5/10/2024
Status: ✅ Merged
Merged: 5/13/2024
Merged by: @bioball

Base: main ← Head: windows-safe-paths

📝 Commits (2)

a4cf786 Improve URI encoding in pkldoc
de4d78b Encode filepaths to be safe on Windows

📊 Changes

132 files changed (+2687 additions, -2617 deletions)

View changed files

📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt (+1 -1)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliPackageDownloaderTest.kt (+14 -14)
📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/KotlinCodeGenerator.kt (+3 -2)
📝 pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/KotlinCodeGeneratorTest.kt (+18 -0)
📝 pkl-commons-test/src/main/kotlin/org/pkl/commons/test/PackageServer.kt (+8 -1)
📝 pkl-config-java/src/main/java/org/pkl/config/java/mapper/ClassRegistry.java (+2 -1)
📝 pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java (+5 -3)
📝 pkl-core/src/main/java/org/pkl/core/util/IoUtils.java (+24 -0)
📝 pkl-core/src/test/kotlin/org/pkl/core/util/IoUtilsTest.kt (+10 -0)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/DocGenerator.kt (+1 -1)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/DocPackageInfo.kt (+2 -2)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/DocScope.kt (+17 -21)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/PackageDataGenerator.kt (+5 -3)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/RuntimeDataGenerator.kt (+57 -46)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/SearchIndexGenerator.kt (+1 -1)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/Util.kt (+7 -14)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/Module Containing Spaces/index.html (+24 -24)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/baseModule/BaseClass.html (+21 -21)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/baseModule/index.html (+26 -26)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/classAnnotations/AnnotatedClass.html (+21 -21)

...and 80 more files

📄 Description

Also: don't URI-encode parentheses in pkldoc.

Implementation for SPICE-0003

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/489 **Author:** [@bioball](https://github.com/bioball) **Created:** 5/10/2024 **Status:** ✅ Merged **Merged:** 5/13/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `windows-safe-paths` --- ### 📝 Commits (2) - [`a4cf786`](https://github.com/apple/pkl/commit/a4cf786354dd01ea7ef613f056b35247b08a96b1) Improve URI encoding in pkldoc - [`de4d78b`](https://github.com/apple/pkl/commit/de4d78b1d1b9aa1ea47a8e18227267f7f97018b8) Encode filepaths to be safe on Windows ### 📊 Changes **132 files changed** (+2687 additions, -2617 deletions) <details> <summary>View changed files</summary> 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt` (+1 -1) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliPackageDownloaderTest.kt` (+14 -14) 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/KotlinCodeGenerator.kt` (+3 -2) 📝 `pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/KotlinCodeGeneratorTest.kt` (+18 -0) 📝 `pkl-commons-test/src/main/kotlin/org/pkl/commons/test/PackageServer.kt` (+8 -1) 📝 `pkl-config-java/src/main/java/org/pkl/config/java/mapper/ClassRegistry.java` (+2 -1) 📝 `pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java` (+5 -3) 📝 `pkl-core/src/main/java/org/pkl/core/util/IoUtils.java` (+24 -0) 📝 `pkl-core/src/test/kotlin/org/pkl/core/util/IoUtilsTest.kt` (+10 -0) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/DocGenerator.kt` (+1 -1) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/DocPackageInfo.kt` (+2 -2) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/DocScope.kt` (+17 -21) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/PackageDataGenerator.kt` (+5 -3) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/RuntimeDataGenerator.kt` (+57 -46) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/SearchIndexGenerator.kt` (+1 -1) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/Util.kt` (+7 -14) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/Module Containing Spaces/index.html` (+24 -24) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/baseModule/BaseClass.html` (+21 -21) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/baseModule/index.html` (+26 -26) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/classAnnotations/AnnotatedClass.html` (+21 -21) _...and 80 more files_ </details> ### 📄 Description Also: don't URI-encode parentheses in pkldoc. Implementation for [SPICE-0003](https://github.com/apple/pkl-evolution/pull/3) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:25:27 +01:00

adam closed this issue

2025-12-30 01:25:28 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#581