[PR #491] [MERGED] Update amending example #579

New Issue

adam · 2025-12-30T01:25:27+01:00

adam commented

2025-12-30 01:25:27 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/491
Author: @nirinchev
Created: 5/13/2024
Status: ✅ Merged
Merged: 5/17/2024
Merged by: @holzensp

Base: main ← Head: ni/ammend-tutorial

📝 Commits (2)

195ade1 Update amending example
456e879 Make sure wood pigeon amends stock pigeon

📊 Changes

1 file changed (+27 additions, -15 deletions)

View changed files

📝 docs/modules/language-tutorial/pages/02_filling_out_a_template.adoc (+27 -15)

📄 Description

Looking through the Ammending section of the "Filling out a template" tutorial, it seemed like the code snippets and the textual explanation didn't align nicely. I've updated the code snippets to match the text surrounding them as it seemed like the text was the correct one. Here's a summary of changes:

Swapped out the relationship between stock and wood pigeon - it appeared like wood pigeon should be amending stock pigeon rather than the other way around.
Added kingdom, clade, and order to stockPigeon.taxonomy as the text was referencing those fields, but those were missing from the code snippet.
Updated the output snippet to reflect the code reorganization.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/491 **Author:** [@nirinchev](https://github.com/nirinchev) **Created:** 5/13/2024 **Status:** ✅ Merged **Merged:** 5/17/2024 **Merged by:** [@holzensp](https://github.com/holzensp) **Base:** `main` ← **Head:** `ni/ammend-tutorial` --- ### 📝 Commits (2) - [`195ade1`](https://github.com/apple/pkl/commit/195ade19a5c43552b9bf848a81a71ac44822ab5f) Update amending example - [`456e879`](https://github.com/apple/pkl/commit/456e8797274113561d657d95cabad984d4c4ab73) Make sure wood pigeon amends stock pigeon ### 📊 Changes **1 file changed** (+27 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/language-tutorial/pages/02_filling_out_a_template.adoc` (+27 -15) </details> ### 📄 Description Looking through the [Ammending](https://pkl-lang.org/main/current/language-tutorial/02_filling_out_a_template.html#amending) section of the "Filling out a template" tutorial, it seemed like the code snippets and the textual explanation didn't align nicely. I've updated the code snippets to match the text surrounding them as it seemed like the text was the correct one. Here's a summary of changes: 1. Swapped out the relationship between stock and wood pigeon - it appeared like wood pigeon should be amending stock pigeon rather than the other way around. 2. Added `kingdom`, `clade`, and `order` to `stockPigeon.taxonomy` as the text was referencing those fields, but those were missing from the code snippet. 3. Updated the output snippet to reflect the code reorganization. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:25:27 +01:00

adam closed this issue

2025-12-30 01:25:27 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#579