[PR #486] [MERGED] Support scheme-agnostic projects #577

Closed
opened 2025-12-30 01:25:26 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/486
Author: @bioball
Created: 5/10/2024
Status: Merged
Merged: 6/5/2024
Merged by: @bioball

Base: mainHead: projects-from-any-uri


📝 Commits (4)

  • 4a63fb8 Support Projects loaded from arbitrary URIs
  • ed52fe3 Adjustments in accordance with SPICE-0005
  • fc200fa Address PR comments
  • 0258094 Clean up merge conflict issues

📊 Changes

49 files changed (+763 additions, -234 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/EvaluatorImpl.java (+2 -1)
📝 pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java (+2 -0)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/unary/ReadGlobNode.java (+4 -2)
📝 pkl-core/src/main/java/org/pkl/core/module/ModuleKeys.java (+83 -108)
📝 pkl-core/src/main/java/org/pkl/core/module/ProjectDependenciesManager.java (+43 -21)
📝 pkl-core/src/main/java/org/pkl/core/module/ResolvedModuleKeys.java (+34 -0)
📝 pkl-core/src/main/java/org/pkl/core/packages/Dependency.java (+4 -2)
📝 pkl-core/src/main/java/org/pkl/core/project/Project.java (+84 -23)
📝 pkl-core/src/main/java/org/pkl/core/project/ProjectPackager.java (+10 -1)
📝 pkl-core/src/main/java/org/pkl/core/repl/ReplServer.java (+3 -1)
📝 pkl-core/src/main/java/org/pkl/core/resource/ResourceReaders.java (+25 -14)
📝 pkl-core/src/main/java/org/pkl/core/runtime/ResourceManager.java (+22 -7)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmExceptionBuilder.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/util/GlobResolver.java (+9 -1)
📝 pkl-core/src/main/java/org/pkl/core/util/IoUtils.java (+68 -17)
📝 pkl-core/src/main/resources/org/pkl/core/errorMessages.properties (+32 -3)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/projects/project1/PklProject (+1 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/projects/project1/PklProject.deps.json (+5 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/projects/project1/globbing.pkl (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/projects/project3/PklProject.deps.json (+5 -0)

...and 29 more files

📄 Description

Supercedes and closes #255


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/486 **Author:** [@bioball](https://github.com/bioball) **Created:** 5/10/2024 **Status:** ✅ Merged **Merged:** 6/5/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `projects-from-any-uri` --- ### 📝 Commits (4) - [`4a63fb8`](https://github.com/apple/pkl/commit/4a63fb885c4e5c9ecb553421d892aef6926d9e32) Support Projects loaded from arbitrary URIs - [`ed52fe3`](https://github.com/apple/pkl/commit/ed52fe33c1ae7dcaeb5aa6a90a9032926cdcb9a8) Adjustments in accordance with SPICE-0005 - [`fc200fa`](https://github.com/apple/pkl/commit/fc200fa1a248af639b948cf1560231f0b1abdfcc) Address PR comments - [`0258094`](https://github.com/apple/pkl/commit/02580945e0f5f67f70534cff63bb5cdfad6a7c95) Clean up merge conflict issues ### 📊 Changes **49 files changed** (+763 additions, -234 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/EvaluatorImpl.java` (+2 -1) 📝 `pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java` (+2 -0) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/unary/ReadGlobNode.java` (+4 -2) 📝 `pkl-core/src/main/java/org/pkl/core/module/ModuleKeys.java` (+83 -108) 📝 `pkl-core/src/main/java/org/pkl/core/module/ProjectDependenciesManager.java` (+43 -21) 📝 `pkl-core/src/main/java/org/pkl/core/module/ResolvedModuleKeys.java` (+34 -0) 📝 `pkl-core/src/main/java/org/pkl/core/packages/Dependency.java` (+4 -2) 📝 `pkl-core/src/main/java/org/pkl/core/project/Project.java` (+84 -23) 📝 `pkl-core/src/main/java/org/pkl/core/project/ProjectPackager.java` (+10 -1) 📝 `pkl-core/src/main/java/org/pkl/core/repl/ReplServer.java` (+3 -1) 📝 `pkl-core/src/main/java/org/pkl/core/resource/ResourceReaders.java` (+25 -14) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/ResourceManager.java` (+22 -7) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmExceptionBuilder.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/util/GlobResolver.java` (+9 -1) 📝 `pkl-core/src/main/java/org/pkl/core/util/IoUtils.java` (+68 -17) 📝 `pkl-core/src/main/resources/org/pkl/core/errorMessages.properties` (+32 -3) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/projects/project1/PklProject` (+1 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/projects/project1/PklProject.deps.json` (+5 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/projects/project1/globbing.pkl` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/projects/project3/PklProject.deps.json` (+5 -0) _...and 29 more files_ </details> ### 📄 Description Supercedes and closes #255 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:26 +01:00
adam closed this issue 2025-12-30 01:25:26 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#577