[PR #480] [MERGED] Handle null pathElements gracefully in message passing API #575

New Issue

adam · 2025-12-30T01:25:25+01:00

adam commented

2025-12-30 01:25:25 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/480
Author: @bioball
Created: 5/8/2024
Status: ✅ Merged
Merged: 5/8/2024
Merged by: @bioball

Base: main ← Head: handle-null-path-elements

📝 Commits (1)

a50f6a0 Handle null pathElements gracefully in message passing API

📊 Changes

4 files changed (+86 additions, -4 deletions)

View changed files

📝 docs/modules/bindings-specification/pages/message-passing-api.adoc (+4 -0)
📝 pkl-server/src/main/kotlin/org/pkl/server/ClientModuleKeyFactory.kt (+1 -1)
📝 pkl-server/src/main/kotlin/org/pkl/server/ClientResourceReader.kt (+3 -3)
📝 pkl-server/src/test/kotlin/org/pkl/server/ServerTest.kt (+78 -0)

📄 Description

In messages "List Resources Response" and "List Modules Response", if pathElements and error are both null, default to an empty list.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/480 **Author:** [@bioball](https://github.com/bioball) **Created:** 5/8/2024 **Status:** ✅ Merged **Merged:** 5/8/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `handle-null-path-elements` --- ### 📝 Commits (1) - [`a50f6a0`](https://github.com/apple/pkl/commit/a50f6a0d99d746cd3d61e461fd2f0cdf00ff0d7c) Handle `null` pathElements gracefully in message passing API ### 📊 Changes **4 files changed** (+86 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/bindings-specification/pages/message-passing-api.adoc` (+4 -0) 📝 `pkl-server/src/main/kotlin/org/pkl/server/ClientModuleKeyFactory.kt` (+1 -1) 📝 `pkl-server/src/main/kotlin/org/pkl/server/ClientResourceReader.kt` (+3 -3) 📝 `pkl-server/src/test/kotlin/org/pkl/server/ServerTest.kt` (+78 -0) </details> ### 📄 Description In messages "List Resources Response" and "List Modules Response", if `pathElements` and `error` are both null, default to an empty list. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:25:25 +01:00

adam closed this issue

2025-12-30 01:25:25 +01:00

adam referenced this issue

2025-12-30 01:25:43 +01:00

[PR #575] [CLOSED] Fix default value evaluation in toTyped() #626

Sign in to join this conversation.