starred/pkl
1
0 Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-11-13 20:33:30 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #477] [MERGED] Require global settings file to use pkl:settings #574

New Issue
Closed
opened 2025-12-30 01:25:25 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:25 +01:00
Owner
Copy link
Copy source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/477
Author: @bioball
Created: 5/6/2024
Status: ✅ Merged
Merged: 5/7/2024
Merged by: @bioball

Base: main ← Head: settings-module-cleanup

📝 Commits (1)

  • a9918aa Require global settings file to use pkl:settings

📊 Changes

5 files changed (+19 additions, -19 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/PClassInfo.java (+3 -0)
📝 pkl-core/src/main/java/org/pkl/core/runtime/SettingsModule.java (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/settings/PklSettings.java (+6 -14)
📝 pkl-core/src/main/resources/org/pkl/core/errorMessages.properties (+0 -3)
📝 pkl-core/src/test/kotlin/org/pkl/core/settings/PklSettingsTest.kt (+8 -0)

📄 Description

This is technically a breaking change, but follows the intended use-case and documentation of settings.

  • Require that the global settings file at ~/.pkl/settings.pkl amends stdlib module pkl:settings, or otherwise sets output.value to an instance of pkl.Settings.
  • Simplify the object mapping of PklSettings.java

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/477 **Author:** [@bioball](https://github.com/bioball) **Created:** 5/6/2024 **Status:** ✅ Merged **Merged:** 5/7/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `settings-module-cleanup` --- ### 📝 Commits (1) - [`a9918aa`](https://github.com/apple/pkl/commit/a9918aa7edf3e1d1a40c7f5742a597b3af683556) Require global settings file to use `pkl:settings` ### 📊 Changes **5 files changed** (+19 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/PClassInfo.java` (+3 -0) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/SettingsModule.java` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/settings/PklSettings.java` (+6 -14) 📝 `pkl-core/src/main/resources/org/pkl/core/errorMessages.properties` (+0 -3) 📝 `pkl-core/src/test/kotlin/org/pkl/core/settings/PklSettingsTest.kt` (+8 -0) </details> ### 📄 Description This is technically a breaking change, but follows the intended use-case and documentation of settings. * Require that the global settings file at `~/.pkl/settings.pkl` amends stdlib module `pkl:settings`, or otherwise sets `output.value` to an instance of `pkl.Settings`. * Simplify the object mapping of `PklSettings.java` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:25 +01:00
adam closed this issue 2025-12-30 01:25:25 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#574