starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #471] [MERGED] Declare members of http package NonnullByDefault #571

New Issue
Closed
opened 2025-12-30 01:25:24 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:24 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/471
Author: @bioball
Created: 5/3/2024
Status: ✅ Merged
Merged: 5/3/2024
Merged by: @bioball

Base: main ← Head: http-package-info

📝 Commits (1)

  • 12101b0 Declare members of http package NonnullByDefault

📊 Changes

2 files changed (+30 additions, -2 deletions)

View changed files

➕ pkl-core/src/main/java/org/pkl/core/http/package-info.java (+4 -0)
📝 pkl-core/src/test/kotlin/org/pkl/core/http/RequestCapturingClient.kt (+26 -2)

📄 Description

  • Add a package-info.java with NonnullByDefault annotation
  • Make RequestCapturingClient return a response to satisfy the type checker

CC @translatenix

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/471 **Author:** [@bioball](https://github.com/bioball) **Created:** 5/3/2024 **Status:** ✅ Merged **Merged:** 5/3/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `http-package-info` --- ### 📝 Commits (1) - [`12101b0`](https://github.com/apple/pkl/commit/12101b049a10501b33029e406ed9dc2f87dd7f91) Declare members of http package NonnullByDefault ### 📊 Changes **2 files changed** (+30 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `pkl-core/src/main/java/org/pkl/core/http/package-info.java` (+4 -0) 📝 `pkl-core/src/test/kotlin/org/pkl/core/http/RequestCapturingClient.kt` (+26 -2) </details> ### 📄 Description * Add a package-info.java with NonnullByDefault annotation * Make RequestCapturingClient return a response to satisfy the type checker CC @translatenix --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:24 +01:00
adam closed this issue 2025-12-30 01:25:24 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#571
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?