starred/pkl
1
0 Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-11-13 12:23:51 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #470] [MERGED] Remove hidden modifier from many reflect properties for better equality/rendering #570

New Issue
Closed
opened 2025-12-30 01:25:23 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:23 +01:00
Owner
Copy link
Copy source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/470
Author: @stackoverflow
Created: 5/2/2024
Status: ✅ Merged
Merged: 5/3/2024
Merged by: @stackoverflow

Base: main ← Head: fix-pkl-reflect-equality

📝 Commits (4)

  • 50b2a46 remove hidden modifier from many reflect properties for better equality/rendering
  • 1a350be fix review remark
  • 628fcd4 match the commit id directly
  • 3fad1be rename hash to $commitId

📊 Changes

3 files changed (+1748 additions, -5 deletions)

View changed files

📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/reflectedDeclaration.pcf (+1739 -0)
📝 pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt (+5 -1)
📝 stdlib/reflect.pkl (+4 -4)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/470 **Author:** [@stackoverflow](https://github.com/stackoverflow) **Created:** 5/2/2024 **Status:** ✅ Merged **Merged:** 5/3/2024 **Merged by:** [@stackoverflow](https://github.com/stackoverflow) **Base:** `main` ← **Head:** `fix-pkl-reflect-equality` --- ### 📝 Commits (4) - [`50b2a46`](https://github.com/apple/pkl/commit/50b2a461db6e5bbd26f6e9ec167c3682957c8efe) remove hidden modifier from many reflect properties for better equality/rendering - [`1a350be`](https://github.com/apple/pkl/commit/1a350be0b0751165c0cba32351d6882cef56aa52) fix review remark - [`628fcd4`](https://github.com/apple/pkl/commit/628fcd47e94758484a4b5f7ed780c06411af2406) match the commit id directly - [`3fad1be`](https://github.com/apple/pkl/commit/3fad1bec0ea839141c807189b3a806f35d06caad) rename _hash_ to $commitId ### 📊 Changes **3 files changed** (+1748 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/reflectedDeclaration.pcf` (+1739 -0) 📝 `pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt` (+5 -1) 📝 `stdlib/reflect.pkl` (+4 -4) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:23 +01:00
adam closed this issue 2025-12-30 01:25:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#570