starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 14:20:35 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #468] [MERGED] [Fix][CI] Use JDK 17 image for deploy-snapshot job #567

New Issue
Closed
opened 2025-12-30 01:25:22 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:22 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/468
Author: @fumiya-kume
Created: 5/1/2024
Status: ✅ Merged
Merged: 5/1/2024
Merged by: @bioball

Base: main ← Head: patch-1

📝 Commits (3)

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 .circleci/config.yml (+2 -2)
📝 .circleci/jobs/DeployJob.pkl (+1 -1)

📄 Description

Cause

The CI is failing for deploy-snapshot job.
Ref: https://app.circleci.com/pipelines/github/apple/pkl/760/workflows/b39c0772-56db-4ba3-a5bc-edef38e25bc2/jobs/4203

The reason is that using image is JDK11.0, but we specify the 17.0

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/468 **Author:** [@fumiya-kume](https://github.com/fumiya-kume) **Created:** 5/1/2024 **Status:** ✅ Merged **Merged:** 5/1/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (3) - [`a2d5d27`](https://github.com/apple/pkl/commit/a2d5d271c224d773bea9469864204e2e9bcd1c5e) Use JDK 17 image for deploy-snapshot job - [`954833e`](https://github.com/apple/pkl/commit/954833e3d64792ff958996f2ec63dc1f36da776b) Revert change - [`b34f4fd`](https://github.com/apple/pkl/commit/b34f4fd07a8d766cf4b79779754f3b14db323bec) Use Java17 for deploy ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.circleci/config.yml` (+2 -2) 📝 `.circleci/jobs/DeployJob.pkl` (+1 -1) </details> ### 📄 Description # Cause The CI is failing for deploy-snapshot job. Ref: https://app.circleci.com/pipelines/github/apple/pkl/760/workflows/b39c0772-56db-4ba3-a5bc-edef38e25bc2/jobs/4203 The reason is that using image is JDK11.0, but we specify the 17.0 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:22 +01:00
adam closed this issue 2025-12-30 01:25:22 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#567
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?