starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #451] [MERGED] Leverage basic Java 17 features #557

New Issue
Closed
opened 2025-12-30 01:25:19 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:19 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/451
Author: @odenix
Created: 4/25/2024
Status: ✅ Merged
Merged: 4/25/2024
Merged by: @bioball

Base: main ← Head: jdk-17

📝 Commits (2)

  • b117fbc Leverage basic Java 17 features
  • 147a69d Apply suggestions from code review

📊 Changes

142 files changed (+1331 additions, -1796 deletions)

View changed files

📝 bench/src/jmh/java/org/pkl/core/ListSort.java (+2 -2)
📝 pkl-config-java/src/main/java/org/pkl/config/java/AbstractConfig.java (+4 -4)
📝 pkl-config-java/src/main/java/org/pkl/config/java/JavaType.java (+3 -5)
📝 pkl-config-java/src/main/java/org/pkl/config/java/mapper/PNullToAny.java (+1 -1)
📝 pkl-config-java/src/main/java/org/pkl/config/java/mapper/Reflection.java (+6 -8)
📝 pkl-config-java/src/main/java/org/pkl/config/java/mapper/Tuple2.java (+1 -4)
📝 pkl-config-java/src/main/java/org/pkl/config/java/mapper/TypeMapping.java (+1 -3)
📝 pkl-config-java/src/main/java/org/pkl/config/java/mapper/Types.java (+1 -2)
📝 pkl-config-java/src/main/java/org/pkl/config/java/mapper/ValueMapperBuilder.java (+1 -2)
📝 pkl-config-java/src/test/java/org/pkl/config/java/mapper/PObjectToDataObjectJavaxInjectTest.java (+3 -9)
📝 pkl-config-java/src/test/java/org/pkl/config/java/mapper/PObjectToDataObjectTest.java (+4 -12)
📝 pkl-config-java/src/test/java/org/pkl/config/java/mapper/Person.java (+1 -3)
📝 pkl-core/src/main/java/org/pkl/core/DataSize.java (+3 -4)
📝 pkl-core/src/main/java/org/pkl/core/DataSizeUnit.java (+14 -26)
📝 pkl-core/src/main/java/org/pkl/core/Duration.java (+3 -4)
📝 pkl-core/src/main/java/org/pkl/core/DurationUnit.java (+19 -36)
📝 pkl-core/src/main/java/org/pkl/core/EvaluatorImpl.java (+5 -8)
📝 pkl-core/src/main/java/org/pkl/core/Member.java (+3 -4)
📝 pkl-core/src/main/java/org/pkl/core/PClass.java (+5 -7)
📝 pkl-core/src/main/java/org/pkl/core/PClassInfo.java (+4 -6)

...and 80 more files

📄 Description

Changes:

  • Refactor code to use the following basic Java 17 features:
    • pattern matching for instanceof
    • @Serial annotation
    • switch expressions
    • enhanced switch statements
    • StringBuilder.isEmpty()
  • Replace two switch statements with simpler if statements.
  • Rename a few local variables.

Result:
Better code, fewer IntelliJ warnings

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/451 **Author:** [@odenix](https://github.com/odenix) **Created:** 4/25/2024 **Status:** ✅ Merged **Merged:** 4/25/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `jdk-17` --- ### 📝 Commits (2) - [`b117fbc`](https://github.com/apple/pkl/commit/b117fbc923e08b819422a840af25155a749de379) Leverage basic Java 17 features - [`147a69d`](https://github.com/apple/pkl/commit/147a69d4ff80e7faeac3803e0fae4f026294cb43) Apply suggestions from code review ### 📊 Changes **142 files changed** (+1331 additions, -1796 deletions) <details> <summary>View changed files</summary> 📝 `bench/src/jmh/java/org/pkl/core/ListSort.java` (+2 -2) 📝 `pkl-config-java/src/main/java/org/pkl/config/java/AbstractConfig.java` (+4 -4) 📝 `pkl-config-java/src/main/java/org/pkl/config/java/JavaType.java` (+3 -5) 📝 `pkl-config-java/src/main/java/org/pkl/config/java/mapper/PNullToAny.java` (+1 -1) 📝 `pkl-config-java/src/main/java/org/pkl/config/java/mapper/Reflection.java` (+6 -8) 📝 `pkl-config-java/src/main/java/org/pkl/config/java/mapper/Tuple2.java` (+1 -4) 📝 `pkl-config-java/src/main/java/org/pkl/config/java/mapper/TypeMapping.java` (+1 -3) 📝 `pkl-config-java/src/main/java/org/pkl/config/java/mapper/Types.java` (+1 -2) 📝 `pkl-config-java/src/main/java/org/pkl/config/java/mapper/ValueMapperBuilder.java` (+1 -2) 📝 `pkl-config-java/src/test/java/org/pkl/config/java/mapper/PObjectToDataObjectJavaxInjectTest.java` (+3 -9) 📝 `pkl-config-java/src/test/java/org/pkl/config/java/mapper/PObjectToDataObjectTest.java` (+4 -12) 📝 `pkl-config-java/src/test/java/org/pkl/config/java/mapper/Person.java` (+1 -3) 📝 `pkl-core/src/main/java/org/pkl/core/DataSize.java` (+3 -4) 📝 `pkl-core/src/main/java/org/pkl/core/DataSizeUnit.java` (+14 -26) 📝 `pkl-core/src/main/java/org/pkl/core/Duration.java` (+3 -4) 📝 `pkl-core/src/main/java/org/pkl/core/DurationUnit.java` (+19 -36) 📝 `pkl-core/src/main/java/org/pkl/core/EvaluatorImpl.java` (+5 -8) 📝 `pkl-core/src/main/java/org/pkl/core/Member.java` (+3 -4) 📝 `pkl-core/src/main/java/org/pkl/core/PClass.java` (+5 -7) 📝 `pkl-core/src/main/java/org/pkl/core/PClassInfo.java` (+4 -6) _...and 80 more files_ </details> ### 📄 Description Changes: - Refactor code to use the following basic Java 17 features: - pattern matching for instanceof - `@Serial` annotation - switch expressions - enhanced switch statements - `StringBuilder.isEmpty()` - Replace two switch statements with simpler if statements. - Rename a few local variables. Result: Better code, fewer IntelliJ warnings --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:19 +01:00
adam closed this issue 2025-12-30 01:25:19 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#557
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?