[PR #439] [MERGED] Drop java 11, bump GraalVM to 23.0 #556

Closed
opened 2025-12-30 01:25:18 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/439
Author: @bioball
Created: 4/18/2024
Status: Merged
Merged: 4/25/2024
Merged by: @bioball

Base: mainHead: drop-java-11


📝 Commits (3)

  • a2200e8 Drop Java 11, bump GraalVM to 23.0
  • 7aa6378 Address PR nits
  • dc9a348 Remove native build jobs from PRB

📊 Changes

55 files changed (+252 additions, -953 deletions)

View changed files

📝 .circleci/config.pkl (+1 -22)
📝 .circleci/config.yml (+10 -70)
📝 .circleci/jobs/BuildNativeJob.pkl (+2 -12)
📝 bench/bench.gradle.kts (+2 -2)
📝 bench/gradle.lockfile (+3 -3)
📝 buildSrc/build.gradle.kts (+3 -3)
📝 buildSrc/src/main/kotlin/BuildInfo.kt (+9 -31)
📝 buildSrc/src/main/kotlin/pklAllProjects.gradle.kts (+3 -3)
📝 buildSrc/src/main/kotlin/pklGraalVm.gradle.kts (+48 -23)
📝 buildSrc/src/main/kotlin/pklJavaLibrary.gradle.kts (+3 -0)
📝 docs/gradle.lockfile (+2 -2)
📝 gradle/libs.versions.toml (+7 -7)
patches/graalVm23.patch (+0 -683)
📝 pkl-cli/gradle.lockfile (+7 -7)
📝 pkl-cli/pkl-cli.gradle.kts (+43 -23)
📝 pkl-codegen-java/gradle.lockfile (+2 -2)
📝 pkl-codegen-kotlin/gradle.lockfile (+2 -2)
📝 pkl-commons-cli/gradle.lockfile (+2 -2)
📝 pkl-config-java/gradle.lockfile (+2 -2)
📝 pkl-config-kotlin/gradle.lockfile (+2 -2)

...and 35 more files

📄 Description

Note: I enabled build native jobs here because this PRB introduces changes there. I'm planning on getting rid of them again before merging.

A remaining TODO here is to tune our specialization limits (see commit for details)

After dropping Java 11, we can start using records, and also switch our Java code generators to use records.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/439 **Author:** [@bioball](https://github.com/bioball) **Created:** 4/18/2024 **Status:** ✅ Merged **Merged:** 4/25/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `drop-java-11` --- ### 📝 Commits (3) - [`a2200e8`](https://github.com/apple/pkl/commit/a2200e8c11a3ed19b3c25cce344e074ad331d536) Drop Java 11, bump GraalVM to 23.0 - [`7aa6378`](https://github.com/apple/pkl/commit/7aa6378f81105290dde239727680d1791442b230) Address PR nits - [`dc9a348`](https://github.com/apple/pkl/commit/dc9a34879bc2f80ef5b8f73363e286a376f0675a) Remove native build jobs from PRB ### 📊 Changes **55 files changed** (+252 additions, -953 deletions) <details> <summary>View changed files</summary> 📝 `.circleci/config.pkl` (+1 -22) 📝 `.circleci/config.yml` (+10 -70) 📝 `.circleci/jobs/BuildNativeJob.pkl` (+2 -12) 📝 `bench/bench.gradle.kts` (+2 -2) 📝 `bench/gradle.lockfile` (+3 -3) 📝 `buildSrc/build.gradle.kts` (+3 -3) 📝 `buildSrc/src/main/kotlin/BuildInfo.kt` (+9 -31) 📝 `buildSrc/src/main/kotlin/pklAllProjects.gradle.kts` (+3 -3) 📝 `buildSrc/src/main/kotlin/pklGraalVm.gradle.kts` (+48 -23) 📝 `buildSrc/src/main/kotlin/pklJavaLibrary.gradle.kts` (+3 -0) 📝 `docs/gradle.lockfile` (+2 -2) 📝 `gradle/libs.versions.toml` (+7 -7) ➖ `patches/graalVm23.patch` (+0 -683) 📝 `pkl-cli/gradle.lockfile` (+7 -7) 📝 `pkl-cli/pkl-cli.gradle.kts` (+43 -23) 📝 `pkl-codegen-java/gradle.lockfile` (+2 -2) 📝 `pkl-codegen-kotlin/gradle.lockfile` (+2 -2) 📝 `pkl-commons-cli/gradle.lockfile` (+2 -2) 📝 `pkl-config-java/gradle.lockfile` (+2 -2) 📝 `pkl-config-kotlin/gradle.lockfile` (+2 -2) _...and 35 more files_ </details> ### 📄 Description Note: I enabled build native jobs here because this PRB introduces changes there. I'm planning on getting rid of them again before merging. A remaining TODO here is to tune our specialization limits (see commit for details) After dropping Java 11, we can start using records, and also switch our Java code generators to use records. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:18 +01:00
adam closed this issue 2025-12-30 01:25:18 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#556