[PR #441] [MERGED] Fix: fatal error when chart location is invalid #554

Closed
opened 2025-12-30 01:25:18 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/441
Author: @MarkSRobinson
Created: 4/21/2024
Status: Merged
Merged: 4/29/2024
Merged by: @holzensp

Base: mainHead: main


📝 Commits (6)

  • 606dc88 Fix handling of other http error codes when creating packages
  • 16330bf Merge remote-tracking branch 'msr/main'
  • a4b4e27 Adjust wording in error
  • 962652e Update pkl-core/src/main/resources/org/pkl/core/errorMessages.properties
  • 6157e2f Update pkl-core/src/main/resources/org/pkl/core/errorMessages.properties
  • 05a6d74 Fix error handler to use new message

📊 Changes

2 files changed (+11 additions, -2 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/project/ProjectPackager.java (+8 -2)
📝 pkl-core/src/main/resources/org/pkl/core/errorMessages.properties (+3 -0)

📄 Description

Fixes #429


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/441 **Author:** [@MarkSRobinson](https://github.com/MarkSRobinson) **Created:** 4/21/2024 **Status:** ✅ Merged **Merged:** 4/29/2024 **Merged by:** [@holzensp](https://github.com/holzensp) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (6) - [`606dc88`](https://github.com/apple/pkl/commit/606dc8831f7afa889f0ef57b01ee6c245c82d52e) Fix handling of other http error codes when creating packages - [`16330bf`](https://github.com/apple/pkl/commit/16330bf60399a2eab8197a5d0d49e6bd1da021f5) Merge remote-tracking branch 'msr/main' - [`a4b4e27`](https://github.com/apple/pkl/commit/a4b4e270f0e21c3073d501bd7e84146e78bc7ad4) Adjust wording in error - [`962652e`](https://github.com/apple/pkl/commit/962652e3e5eda4066805a7cf9fe6e5061026167b) Update pkl-core/src/main/resources/org/pkl/core/errorMessages.properties - [`6157e2f`](https://github.com/apple/pkl/commit/6157e2f4a48b67c67e960fad1a309ebf3efdd9e5) Update pkl-core/src/main/resources/org/pkl/core/errorMessages.properties - [`05a6d74`](https://github.com/apple/pkl/commit/05a6d740975a3ead3613a9d56ea7e0282cc74e3a) Fix error handler to use new message ### 📊 Changes **2 files changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/project/ProjectPackager.java` (+8 -2) 📝 `pkl-core/src/main/resources/org/pkl/core/errorMessages.properties` (+3 -0) </details> ### 📄 Description Fixes #429 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:18 +01:00
adam closed this issue 2025-12-30 01:25:18 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#554