starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 14:20:35 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #438] [MERGED] Improve method.isConst() checks #552

New Issue
Closed
opened 2025-12-30 01:25:17 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:17 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/438
Author: @odenix
Created: 4/17/2024
Status: ✅ Merged
Merged: 4/20/2024
Merged by: @bioball

Base: main ← Head: fix-const

📝 Commits (2)

  • e4110bc Improve method.isConst() checks in InvokeMethodVirtualNode
  • c3f1cd8 Improve method.isConst() check in InvokeSuperMethodNode

📊 Changes

5 files changed (+18 additions, -40 deletions)

View changed files

📝 docs/modules/language-reference/pages/index.adoc (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeMethodVirtualNode.java (+8 -18)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeSuperMethodNode.java (+7 -5)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/primary/ResolveVariableNode.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/ast/member/Member.java (+0 -14)

📄 Description

For details see the commit messages.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/438 **Author:** [@odenix](https://github.com/odenix) **Created:** 4/17/2024 **Status:** ✅ Merged **Merged:** 4/20/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-const` --- ### 📝 Commits (2) - [`e4110bc`](https://github.com/apple/pkl/commit/e4110bc3bf937ec137ed6ef34e66e1f94cfaf25b) Improve method.isConst() checks in InvokeMethodVirtualNode - [`c3f1cd8`](https://github.com/apple/pkl/commit/c3f1cd8e4d5fb97a8542a2286e8ee6243349d2dd) Improve method.isConst() check in InvokeSuperMethodNode ### 📊 Changes **5 files changed** (+18 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/language-reference/pages/index.adoc` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeMethodVirtualNode.java` (+8 -18) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeSuperMethodNode.java` (+7 -5) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/primary/ResolveVariableNode.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/ast/member/Member.java` (+0 -14) </details> ### 📄 Description For details see the commit messages. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:17 +01:00
adam closed this issue 2025-12-30 01:25:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#552
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?