starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #403] [MERGED] Make EvalTask track resolved output paths #538

New Issue
Closed
opened 2025-12-30 01:25:12 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/403
Author: @bioball
Created: 4/5/2024
Status: ✅ Merged
Merged: 7/26/2024
Merged by: @bioball

Base: main ← Head: revert-tracked-eval

📝 Commits (10+)

  • 929d882 Revert "Turn EvalTask into a tracked Gradle task"
  • 0ca03a7 Update comment with detailed explanation
  • 55de0ae Make EvalTask tracked again, and add derived output paths
  • 70cfff7 Make getOutputFormat() a tracked input
  • 063a2c6 Create a provider via provider factory
  • 1becaec Use SetProperty to enable proper dependency tracking
  • a208562 Style fix
  • b027056 Reimplemented tracking of output files in EvalTask
  • 60c8043 Cleanup: rename output properties
  • 6ce42b5 Fix merge conflict

📊 Changes

5 files changed (+364 additions, -25 deletions)

View changed files

📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt (+4 -3)
📝 pkl-gradle/src/main/java/org/pkl/gradle/task/BasePklTask.java (+10 -0)
📝 pkl-gradle/src/main/java/org/pkl/gradle/task/EvalTask.java (+52 -20)
📝 pkl-gradle/src/main/java/org/pkl/gradle/task/ModulesTask.java (+4 -1)
📝 pkl-gradle/src/test/kotlin/org/pkl/gradle/EvaluatorsTest.kt (+294 -1)

📄 Description

This makes Gradle track getOutputPaths() and getMultipleFileOutputPaths. These represent the actual outputs of the EvalTask.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/403 **Author:** [@bioball](https://github.com/bioball) **Created:** 4/5/2024 **Status:** ✅ Merged **Merged:** 7/26/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `revert-tracked-eval` --- ### 📝 Commits (10+) - [`929d882`](https://github.com/apple/pkl/commit/929d882af3b50e74bb000a84af01b3265868b35c) Revert "Turn EvalTask into a tracked Gradle task" - [`0ca03a7`](https://github.com/apple/pkl/commit/0ca03a790d52d23b70c6cbea061ed1d7a4c4f4a6) Update comment with detailed explanation - [`55de0ae`](https://github.com/apple/pkl/commit/55de0ae7c0c1ca58b061902d3af48cfec36e42ee) Make EvalTask tracked again, and add derived output paths - [`70cfff7`](https://github.com/apple/pkl/commit/70cfff7cfaf84d23ff0ea5bd656634ad0f5b6d59) Make getOutputFormat() a tracked input - [`063a2c6`](https://github.com/apple/pkl/commit/063a2c6d092b19edc2de6f7e6c8bb7270f2b7657) Create a provider via provider factory - [`1becaec`](https://github.com/apple/pkl/commit/1becaecca8036a82676f8575280b5b6e07c86940) Use SetProperty to enable proper dependency tracking - [`a208562`](https://github.com/apple/pkl/commit/a2085621eb852f5167d29473a557cf0a11e23a52) Style fix - [`b027056`](https://github.com/apple/pkl/commit/b0270560f38aa6955a2735bfd22cd25744aa023d) Reimplemented tracking of output files in EvalTask - [`60c8043`](https://github.com/apple/pkl/commit/60c804330d13e897779d4b8f50702ab0fc6a63cc) Cleanup: rename output properties - [`6ce42b5`](https://github.com/apple/pkl/commit/6ce42b566014f772661c70e0d71d2db1a673b185) Fix merge conflict ### 📊 Changes **5 files changed** (+364 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt` (+4 -3) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/task/BasePklTask.java` (+10 -0) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/task/EvalTask.java` (+52 -20) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/task/ModulesTask.java` (+4 -1) 📝 `pkl-gradle/src/test/kotlin/org/pkl/gradle/EvaluatorsTest.kt` (+294 -1) </details> ### 📄 Description This makes Gradle track `getOutputPaths()` and `getMultipleFileOutputPaths`. These represent the actual outputs of the EvalTask. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:12 +01:00
adam closed this issue 2025-12-30 01:25:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#538
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?