[PR #390] [MERGED] Turn EvalTask into a tracked Gradle task #532

New Issue

adam · 2025-12-30T01:25:10+01:00

adam commented

2025-12-30 01:25:10 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/390
Author: @odenix
Created: 4/3/2024
Status: ✅ Merged
Merged: 4/5/2024
Merged by: @holzensp

Base: main ← Head: eval-task

📝 Commits (1)

754f832 Turn EvalTask into a tracked Gradle task

📊 Changes

1 file changed (+14 additions, -8 deletions)

View changed files

📝 pkl-gradle/src/main/java/org/pkl/gradle/task/EvalTask.java (+14 -8)

📄 Description

Rationale: "Output file names are known only after execution" isn't a legitimate reason to make this task untracked because the output directory is known in this case. This is no different from (say) the JavaCompile task, where only the class file output directory is known upfront. Forum discussion didn't reveal another reason why this task should be untracked.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/390 **Author:** [@odenix](https://github.com/odenix) **Created:** 4/3/2024 **Status:** ✅ Merged **Merged:** 4/5/2024 **Merged by:** [@holzensp](https://github.com/holzensp) **Base:** `main` ← **Head:** `eval-task` --- ### 📝 Commits (1) - [`754f832`](https://github.com/apple/pkl/commit/754f832d427883949601cbdad1dd8d5875a7a552) Turn EvalTask into a tracked Gradle task ### 📊 Changes **1 file changed** (+14 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `pkl-gradle/src/main/java/org/pkl/gradle/task/EvalTask.java` (+14 -8) </details> ### 📄 Description Rationale: "Output file names are known only after execution" isn't a legitimate reason to make this task untracked because the output directory is known in this case. This is no different from (say) the `JavaCompile` task, where only the class file output directory is known upfront. Forum discussion didn't reveal another reason why this task should be untracked. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:25:10 +01:00

adam closed this issue

2025-12-30 01:25:11 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#532