starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 14:20:35 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #387] [CLOSED] Backport #144 and #373 to 0.25 #531

New Issue
Closed
opened 2025-12-30 01:25:09 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:09 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/387
Author: @HT154
Created: 4/2/2024
Status: ❌ Closed

Base: release/0.25 ← Head: backport-144-373-to-0.25

📝 Commits (2)

  • 4a59cae Fix name resolution in typealias with constraint (#144)
  • 3401e10 Ensure owner and receiver are reset after executing alias (#373)

📊 Changes

13 files changed (+94 additions, -9 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/member/TypeAliasNode.java (+2 -1)
📝 pkl-core/src/main/java/org/pkl/core/ast/type/TypeNode.java (+30 -2)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmTypeAlias.java (+10 -1)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmUtils.java (+8 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input-helper/types/typeAliasConstraint2.pkl (+3 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAlias2.pkl (+7 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAliasConstraint1.pkl (+12 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAliasConstraint2.pkl (+8 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/string.pcf (+4 -4)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/types/typeAlias2.pcf (+4 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/types/typeAliasConstraint1.pcf (+2 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/types/typeAliasConstraint2.pcf (+3 -0)
📝 stdlib/base.pkl (+1 -1)

📄 Description

#144 and #373 contain some critical fixes to typealias resolution that would be great to have available in a published release prior to the planned 0.26 release

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/387 **Author:** [@HT154](https://github.com/HT154) **Created:** 4/2/2024 **Status:** ❌ Closed **Base:** `release/0.25` ← **Head:** `backport-144-373-to-0.25` --- ### 📝 Commits (2) - [`4a59cae`](https://github.com/apple/pkl/commit/4a59cae817032949f460ef1d6f5bfd5aa3f057b4) Fix name resolution in `typealias` with constraint (#144) - [`3401e10`](https://github.com/apple/pkl/commit/3401e10290758696b55ffe554586d66cc0f979d7) Ensure owner and receiver are reset after executing alias (#373) ### 📊 Changes **13 files changed** (+94 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/member/TypeAliasNode.java` (+2 -1) 📝 `pkl-core/src/main/java/org/pkl/core/ast/type/TypeNode.java` (+30 -2) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmTypeAlias.java` (+10 -1) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmUtils.java` (+8 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input-helper/types/typeAliasConstraint2.pkl` (+3 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAlias2.pkl` (+7 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAliasConstraint1.pkl` (+12 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAliasConstraint2.pkl` (+8 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/string.pcf` (+4 -4) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/types/typeAlias2.pcf` (+4 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/types/typeAliasConstraint1.pcf` (+2 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/types/typeAliasConstraint2.pcf` (+3 -0) 📝 `stdlib/base.pkl` (+1 -1) </details> ### 📄 Description #144 and #373 contain some critical fixes to typealias resolution that would be great to have available in a published release prior to the planned 0.26 release --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:09 +01:00
adam closed this issue 2025-12-30 01:25:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#531
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?