starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 15:13:38 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #383] [MERGED] Use Files.newInputStream()/newOutputStream() where appropriate #529

New Issue
Closed
opened 2025-12-30 01:25:09 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:09 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/383
Author: @odenix
Created: 4/2/2024
Status: ✅ Merged
Merged: 4/5/2024
Merged by: @bioball

Base: main ← Head: file-api

📝 Commits (1)

  • 4cc6fc4 Use Files.newInputStream()/newOutputStream() where appropriate

📊 Changes

4 files changed (+5 additions, -10 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/module/ModulePathResolver.java (+1 -2)
📝 pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java (+1 -2)
📝 pkl-core/src/main/java/org/pkl/core/project/ProjectPackager.java (+2 -4)
📝 pkl-core/src/main/java/org/pkl/core/util/IoUtils.java (+1 -2)

📄 Description

Use Files.newInputStream(path) instead of new FileInputStream(path.toFile()) and Files.newOutputStream(path) instead of new FileOutputStream(path.toFile()).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/383 **Author:** [@odenix](https://github.com/odenix) **Created:** 4/2/2024 **Status:** ✅ Merged **Merged:** 4/5/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `file-api` --- ### 📝 Commits (1) - [`4cc6fc4`](https://github.com/apple/pkl/commit/4cc6fc4bbfc71817f3c2cc3bb3e358607cdb928d) Use Files.newInputStream()/newOutputStream() where appropriate ### 📊 Changes **4 files changed** (+5 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/module/ModulePathResolver.java` (+1 -2) 📝 `pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java` (+1 -2) 📝 `pkl-core/src/main/java/org/pkl/core/project/ProjectPackager.java` (+2 -4) 📝 `pkl-core/src/main/java/org/pkl/core/util/IoUtils.java` (+1 -2) </details> ### 📄 Description Use `Files.newInputStream(path)` instead of `new FileInputStream(path.toFile())` and `Files.newOutputStream(path)` instead of `new FileOutputStream(path.toFile())`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:09 +01:00
adam closed this issue 2025-12-30 01:25:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#529
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?