starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 14:20:35 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #373] [MERGED] Ensure owner and receiver are reset after executing alias #527

New Issue
Closed
opened 2025-12-30 01:25:08 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:08 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/373
Author: @bioball
Created: 3/28/2024
Status: ✅ Merged
Merged: 3/28/2024
Merged by: @bioball

Base: main ← Head: typealias-bugfix

📝 Commits (1)

  • 059970d Ensure owner and receiver are reset after executing alias

📊 Changes

3 files changed (+23 additions, -7 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/type/TypeNode.java (+12 -7)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAlias2.pkl (+7 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/types/typeAlias2.pcf (+4 -0)

📄 Description

This fixes an issue where the frame's owner/receiver are not reset if a type test on a typealias fails.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/373 **Author:** [@bioball](https://github.com/bioball) **Created:** 3/28/2024 **Status:** ✅ Merged **Merged:** 3/28/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `typealias-bugfix` --- ### 📝 Commits (1) - [`059970d`](https://github.com/apple/pkl/commit/059970daededf96cf6d67691bc082783abea0a4e) Ensure owner and receiver are reset after executing alias ### 📊 Changes **3 files changed** (+23 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/type/TypeNode.java` (+12 -7) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAlias2.pkl` (+7 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/types/typeAlias2.pcf` (+4 -0) </details> ### 📄 Description This fixes an issue where the frame's owner/receiver are not reset if a type test on a typealias fails. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:08 +01:00
adam closed this issue 2025-12-30 01:25:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#527
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?