starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-09-03 08:27:25 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #372] [MERGED] Fix java/kotlin usage examples #525

New Issue
Closed
opened 2025-12-30 01:25:07 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:07 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/372
Author: @bioball
Created: 3/27/2024
Status: ✅ Merged
Merged: 3/28/2024
Merged by: @bioball

Base: main ← Head: fix-examples

📝 Commits (2)

  • 2ea02ea Fix wrong data type in kotlin example
  • 2770235 Fix Java examples and add to tests

📊 Changes

3 files changed (+6 additions, -4 deletions)

View changed files

📝 docs/docs.gradle.kts (+2 -1)
📝 docs/modules/java-binding/examples/JavaConfigExample.java (+1 -1)
📝 docs/modules/kotlin-binding/examples/KotlinConfigExample.kt (+3 -2)

📄 Description

Fixes wrong data types (string instead of list), and also adds these examples to our unit tests.

Closes #368

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/372 **Author:** [@bioball](https://github.com/bioball) **Created:** 3/27/2024 **Status:** ✅ Merged **Merged:** 3/28/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-examples` --- ### 📝 Commits (2) - [`2ea02ea`](https://github.com/apple/pkl/commit/2ea02ea3a0ba48949f2713ef1d6c70fdb6a35e2b) Fix wrong data type in kotlin example - [`2770235`](https://github.com/apple/pkl/commit/27702357bdc8de576182ccf6c47c13775a3b8e96) Fix Java examples and add to tests ### 📊 Changes **3 files changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `docs/docs.gradle.kts` (+2 -1) 📝 `docs/modules/java-binding/examples/JavaConfigExample.java` (+1 -1) 📝 `docs/modules/kotlin-binding/examples/KotlinConfigExample.kt` (+3 -2) </details> ### 📄 Description Fixes wrong data types (string instead of list), and also adds these examples to our unit tests. Closes #368 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:07 +01:00
adam closed this issue 2025-12-30 01:25:08 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#525