starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 14:20:35 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #357] [MERGED] Avoid resolving paths on fragments #518

New Issue
Closed
opened 2025-12-30 01:25:05 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:05 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/357
Author: @holzensp
Created: 3/22/2024
Status: ✅ Merged
Merged: 3/26/2024
Merged by: @bioball

Base: main ← Head: pholzenspies/docPackageUriFix

📝 Commits (1)

  • bfb053f Avoid resolving paths on fragments

📊 Changes

5 files changed (+5 additions, -5 deletions)

View changed files

📝 pkl-doc/src/main/kotlin/org/pkl/doc/DocPackageInfo.kt (+1 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/localhost:0/birds/0.5.0/Bird/index.html (+1 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/localhost:0/birds/0.5.0/allFruit/index.html (+1 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/localhost:0/birds/0.5.0/catalog/index.html (+1 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/localhost:0/fruit/1.1.0/Fruit/index.html (+1 -1)

📄 Description

The more principled solution is to have importUri be a URI instead of a String and to test its scheme.

Generally, the problem is that URI::resolve can not assume fragments to be a path (and that it discards fragments altogether).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/357 **Author:** [@holzensp](https://github.com/holzensp) **Created:** 3/22/2024 **Status:** ✅ Merged **Merged:** 3/26/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `pholzenspies/docPackageUriFix` --- ### 📝 Commits (1) - [`bfb053f`](https://github.com/apple/pkl/commit/bfb053fc8a59fb79fb2724ed6f74f6139e828558) Avoid resolving paths on fragments ### 📊 Changes **5 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/DocPackageInfo.kt` (+1 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/localhost:0/birds/0.5.0/Bird/index.html` (+1 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/localhost:0/birds/0.5.0/allFruit/index.html` (+1 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/localhost:0/birds/0.5.0/catalog/index.html` (+1 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/localhost:0/fruit/1.1.0/Fruit/index.html` (+1 -1) </details> ### 📄 Description The more principled solution is to have `importUri` be a `URI` instead of a `String` and to test its scheme. Generally, the problem is that `URI::resolve` can not assume fragments to be a path (and that it discards fragments altogether). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:05 +01:00
adam closed this issue 2025-12-30 01:25:05 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#518
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?