[PR #359] [MERGED] Change HttpClientInitException to extend RuntimeException #517

Closed
opened 2025-12-30 01:25:05 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/359
Author: @odenix
Created: 3/22/2024
Status: Merged
Merged: 3/23/2024
Merged by: @bioball

Base: mainHead: http-init


📝 Commits (1)

  • 9f078dd Change HttpClientInitException to extend RuntimeException

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/http/HttpClientInitException.java (+1 -3)

📄 Description

PklException is mainly used to indicate errors during evaluation of Pkl code. It isn't a suitable superclass for HttpClientInitException.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/359 **Author:** [@odenix](https://github.com/odenix) **Created:** 3/22/2024 **Status:** ✅ Merged **Merged:** 3/23/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `http-init` --- ### 📝 Commits (1) - [`9f078dd`](https://github.com/apple/pkl/commit/9f078ddc751d63a5a6aa40f78202163ef9edd3df) Change HttpClientInitException to extend RuntimeException ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/http/HttpClientInitException.java` (+1 -3) </details> ### 📄 Description PklException is mainly used to indicate errors during evaluation of Pkl code. It isn't a suitable superclass for HttpClientInitException. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:05 +01:00
adam closed this issue 2025-12-30 01:25:05 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#517