starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-12 06:40:42 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #345] [MERGED] Replace magic test port 12110 with 0 #513

New Issue
Closed
opened 2025-12-30 01:25:03 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:03 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/345
Author: @odenix
Created: 3/20/2024
Status: ✅ Merged
Merged: 3/20/2024
Merged by: @bioball

Base: main ← Head: magic-port

📝 Commits (2)

  • 2860ebb Replace magic test port 12110 with 0
  • 2069f00 Update pkl-core/src/main/java/org/pkl/core/http/RequestRewritingClient.java

📊 Changes

123 files changed (+469 additions, -469 deletions)

View changed files

📝 pkl-cli/src/test/files/projects/project1/PklProject (+1 -1)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt (+2 -2)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliPackageDownloaderTest.kt (+31 -33)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliProjectPackagerTest.kt (+30 -30)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliProjectResolverTest.kt (+49 -49)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliBaseOptions.kt (+2 -2)
📝 pkl-commons-test/src/main/files/packages/badChecksum@1.0.0/badChecksum@1.0.0.json (+2 -2)
📝 pkl-commons-test/src/main/files/packages/badImportsWithinPackage@1.0.0/badImportsWithinPackage@1.0.0.json (+2 -2)
📝 pkl-commons-test/src/main/files/packages/badPackageZipUrl@1.0.0/badPackageZipUrl@1.0.0.json (+1 -1)
📝 pkl-commons-test/src/main/files/packages/birds@0.5.0/birds@0.5.0.json (+4 -4)
📝 pkl-commons-test/src/main/files/packages/fruit@1.0.5/fruit@1.0.5.json (+2 -2)
📝 pkl-commons-test/src/main/files/packages/fruit@1.1.0/fruit@1.1.0.json (+2 -2)
📝 pkl-commons-test/src/main/files/packages/packageContainingWildcardCharacters@1.0.0/packageContainingWildcardCharacters@1.0.0.json (+2 -2)
📝 pkl-commons-test/src/main/kotlin/org/pkl/commons/test/PackageServer.kt (+6 -2)
📝 pkl-core/src/main/java/org/pkl/core/http/HttpClient.java (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/http/RequestRewritingClient.java (+1 -3)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/basic/importGlob.pkl (+5 -5)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/basic/readGlob.pkl (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/packages/badImport1.error.pkl (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/packages/badImport10.error.pkl (+1 -1)

...and 80 more files

📄 Description

Also introduce constants for some test package SHAs to make them easier to update.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/345 **Author:** [@odenix](https://github.com/odenix) **Created:** 3/20/2024 **Status:** ✅ Merged **Merged:** 3/20/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `magic-port` --- ### 📝 Commits (2) - [`2860ebb`](https://github.com/apple/pkl/commit/2860ebbc324232b8dd61525a41eaf0297abbf749) Replace magic test port 12110 with 0 - [`2069f00`](https://github.com/apple/pkl/commit/2069f005d853bdc27473e271300c2ea42b4086d2) Update pkl-core/src/main/java/org/pkl/core/http/RequestRewritingClient.java ### 📊 Changes **123 files changed** (+469 additions, -469 deletions) <details> <summary>View changed files</summary> 📝 `pkl-cli/src/test/files/projects/project1/PklProject` (+1 -1) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt` (+2 -2) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliPackageDownloaderTest.kt` (+31 -33) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliProjectPackagerTest.kt` (+30 -30) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliProjectResolverTest.kt` (+49 -49) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliBaseOptions.kt` (+2 -2) 📝 `pkl-commons-test/src/main/files/packages/badChecksum@1.0.0/badChecksum@1.0.0.json` (+2 -2) 📝 `pkl-commons-test/src/main/files/packages/badImportsWithinPackage@1.0.0/badImportsWithinPackage@1.0.0.json` (+2 -2) 📝 `pkl-commons-test/src/main/files/packages/badPackageZipUrl@1.0.0/badPackageZipUrl@1.0.0.json` (+1 -1) 📝 `pkl-commons-test/src/main/files/packages/birds@0.5.0/birds@0.5.0.json` (+4 -4) 📝 `pkl-commons-test/src/main/files/packages/fruit@1.0.5/fruit@1.0.5.json` (+2 -2) 📝 `pkl-commons-test/src/main/files/packages/fruit@1.1.0/fruit@1.1.0.json` (+2 -2) 📝 `pkl-commons-test/src/main/files/packages/packageContainingWildcardCharacters@1.0.0/packageContainingWildcardCharacters@1.0.0.json` (+2 -2) 📝 `pkl-commons-test/src/main/kotlin/org/pkl/commons/test/PackageServer.kt` (+6 -2) 📝 `pkl-core/src/main/java/org/pkl/core/http/HttpClient.java` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/http/RequestRewritingClient.java` (+1 -3) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/basic/importGlob.pkl` (+5 -5) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/basic/readGlob.pkl` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/packages/badImport1.error.pkl` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/packages/badImport10.error.pkl` (+1 -1) _...and 80 more files_ </details> ### 📄 Description Also introduce constants for some test package SHAs to make them easier to update. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:03 +01:00
adam closed this issue 2025-12-30 01:25:03 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#513
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?