starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 14:20:35 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #297] [MERGED] fix bug with for generator variables in mixin #493

New Issue
Closed
opened 2025-12-30 01:24:56 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:56 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/297
Author: @stackoverflow
Created: 3/7/2024
Status: ✅ Merged
Merged: 3/7/2024
Merged by: @stackoverflow

Base: main ← Head: cannot-find-property

📝 Commits (3)

  • 647d226 fix bug with for generator variables in mixin
  • f2a5438 fix review remarks
  • a0fa4b1 improve comment

📊 Changes

4 files changed (+31 additions, -1 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/expression/literal/AmendFunctionNode.java (+14 -1)
📝 pkl-core/src/main/java/org/pkl/core/runtime/Identifier.java (+3 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/generators/forGeneratorInMixins.pkl (+10 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/generators/forGeneratorInMixins.pcf (+4 -0)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/297 **Author:** [@stackoverflow](https://github.com/stackoverflow) **Created:** 3/7/2024 **Status:** ✅ Merged **Merged:** 3/7/2024 **Merged by:** [@stackoverflow](https://github.com/stackoverflow) **Base:** `main` ← **Head:** `cannot-find-property` --- ### 📝 Commits (3) - [`647d226`](https://github.com/apple/pkl/commit/647d2265e44a1eeb1a1bd7359c439e2cf6fa0f51) fix bug with for generator variables in mixin - [`f2a5438`](https://github.com/apple/pkl/commit/f2a54387ee710345112f94627f032a8e29271720) fix review remarks - [`a0fa4b1`](https://github.com/apple/pkl/commit/a0fa4b155d3ec864f2a0118f6a00c7b1673eca35) improve comment ### 📊 Changes **4 files changed** (+31 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/literal/AmendFunctionNode.java` (+14 -1) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/Identifier.java` (+3 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/generators/forGeneratorInMixins.pkl` (+10 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/generators/forGeneratorInMixins.pcf` (+4 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:56 +01:00
adam closed this issue 2025-12-30 01:24:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#493
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?