starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #295] [MERGED] Clean up http-client changes #492

New Issue
Closed
opened 2025-12-30 01:24:56 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:56 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/295
Author: @bioball
Created: 3/6/2024
Status: ✅ Merged
Merged: 3/7/2024
Merged by: @bioball

Base: main ← Head: http-client-cleanup

📝 Commits (3)

  • b6e153d Clean up http-client changes
  • 5b9eba0 Address PR comments
  • 0d2601e Switch to creating symlinks for creating historical distributions

📊 Changes

7 files changed (+84 additions, -66 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/http/HttpClientBuilder.java (+9 -8)
📝 pkl-core/src/main/java/org/pkl/core/service/ExecutorSpiImpl.java (+12 -5)
📝 pkl-core/src/main/java/org/pkl/core/util/Exceptions.java (+2 -4)
📝 pkl-core/src/test/kotlin/org/pkl/core/http/HttpClientTest.kt (+25 -24)
📝 pkl-core/src/test/kotlin/org/pkl/core/util/ExceptionsTest.kt (+2 -2)
📝 pkl-executor/pkl-executor.gradle.kts (+24 -7)
📝 pkl-executor/src/test/kotlin/org/pkl/executor/EmbeddedExecutorTest.kt (+10 -16)

📄 Description

  • pkl-excutor tests: copy 0.25.0 distribution into pkl-executable/build
  • Use IoUtils.getPklHomeDir in HttpClientBuilder
  • Simplify Exceptions.java
  • Enable testing for older pkl-executor distribution

(CC @translatenix)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/295 **Author:** [@bioball](https://github.com/bioball) **Created:** 3/6/2024 **Status:** ✅ Merged **Merged:** 3/7/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `http-client-cleanup` --- ### 📝 Commits (3) - [`b6e153d`](https://github.com/apple/pkl/commit/b6e153df44599d551610d259c6eaf3b6c5284ed9) Clean up http-client changes - [`5b9eba0`](https://github.com/apple/pkl/commit/5b9eba08421263d923d990b6fcc3a3109a10e29b) Address PR comments - [`0d2601e`](https://github.com/apple/pkl/commit/0d2601e1297532d5837b12bd35a88907a8e30c6d) Switch to creating symlinks for creating historical distributions ### 📊 Changes **7 files changed** (+84 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/http/HttpClientBuilder.java` (+9 -8) 📝 `pkl-core/src/main/java/org/pkl/core/service/ExecutorSpiImpl.java` (+12 -5) 📝 `pkl-core/src/main/java/org/pkl/core/util/Exceptions.java` (+2 -4) 📝 `pkl-core/src/test/kotlin/org/pkl/core/http/HttpClientTest.kt` (+25 -24) 📝 `pkl-core/src/test/kotlin/org/pkl/core/util/ExceptionsTest.kt` (+2 -2) 📝 `pkl-executor/pkl-executor.gradle.kts` (+24 -7) 📝 `pkl-executor/src/test/kotlin/org/pkl/executor/EmbeddedExecutorTest.kt` (+10 -16) </details> ### 📄 Description * pkl-excutor tests: copy 0.25.0 distribution into pkl-executable/build * Use `IoUtils.getPklHomeDir` in HttpClientBuilder * Simplify Exceptions.java * Enable testing for older pkl-executor distribution (CC @translatenix) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:56 +01:00
adam closed this issue 2025-12-30 01:24:56 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#492
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?