starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 15:13:38 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #271] [MERGED] Revert "Add setting for Kotlin package to codegen (#194)" #488

New Issue
Closed
opened 2025-12-30 01:24:55 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/271
Author: @bioball
Created: 2/29/2024
Status: ✅ Merged
Merged: 3/4/2024
Merged by: @bioball

Base: main ← Head: revert-kotlin-package-setting

📝 Commits (1)

  • 03adcc1 Revert "Add setting for Kotlin package to codegen (#194)"

📊 Changes

7 files changed (+8 additions, -145 deletions)

View changed files

📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorOptions.kt (+1 -10)
📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/KotlinCodeGenerator.kt (+3 -16)
📝 pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/KotlinCodeGeneratorTest.kt (+2 -90)
📝 pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java (+0 -3)
📝 pkl-gradle/src/main/java/org/pkl/gradle/spec/KotlinCodeGenSpec.java (+0 -4)
📝 pkl-gradle/src/main/java/org/pkl/gradle/task/KotlinCodeGenTask.java (+0 -4)
📝 pkl-gradle/src/test/kotlin/org/pkl/gradle/KotlinCodeGeneratorsTest.kt (+2 -18)

📄 Description

This reverts commit 7f404fff49.

The package is derived from the module name.
Having module com.example.Foo in Pkl
will create Kotlin package com.example.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/271 **Author:** [@bioball](https://github.com/bioball) **Created:** 2/29/2024 **Status:** ✅ Merged **Merged:** 3/4/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `revert-kotlin-package-setting` --- ### 📝 Commits (1) - [`03adcc1`](https://github.com/apple/pkl/commit/03adcc141938317cf71e281b346c0a7815ad6877) Revert "Add setting for Kotlin package to codegen (#194)" ### 📊 Changes **7 files changed** (+8 additions, -145 deletions) <details> <summary>View changed files</summary> 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorOptions.kt` (+1 -10) 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/KotlinCodeGenerator.kt` (+3 -16) 📝 `pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/KotlinCodeGeneratorTest.kt` (+2 -90) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java` (+0 -3) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/spec/KotlinCodeGenSpec.java` (+0 -4) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/task/KotlinCodeGenTask.java` (+0 -4) 📝 `pkl-gradle/src/test/kotlin/org/pkl/gradle/KotlinCodeGeneratorsTest.kt` (+2 -18) </details> ### 📄 Description This reverts commit 7f404fff490e2dd883cf9683c21f6fd38fd84518. The package is derived from the module name. Having `module com.example.Foo` in Pkl will create Kotlin `package com.example`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:55 +01:00
adam closed this issue 2025-12-30 01:24:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#488
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?