starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 15:13:38 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #265] [MERGED] Fix: add missing "const" and "fixed" modifiers to reflect API #485

New Issue
Closed
opened 2025-12-30 01:24:54 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:54 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/265
Author: @bioball
Created: 2/29/2024
Status: ✅ Merged
Merged: 2/29/2024
Merged by: @bioball

Base: main ← Head: add-fixed-const-modifiers

📝 Commits (1)

  • 70896ec Fix: add missing "const" and "fixed" modifiers to reflect API (#73)

📊 Changes

5 files changed (+20 additions, -4 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/VmModifier.java (+6 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input-helper/api/reflect/BaseModule.pkl (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/api/reflect1.pkl (+5 -2)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/reflect1.pcf (+4 -1)
📝 stdlib/reflect.pkl (+1 -1)

📄 Description

This fixes an issue where the reflect API does not show fixed or const modifiers on a property.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/265 **Author:** [@bioball](https://github.com/bioball) **Created:** 2/29/2024 **Status:** ✅ Merged **Merged:** 2/29/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `add-fixed-const-modifiers` --- ### 📝 Commits (1) - [`70896ec`](https://github.com/apple/pkl/commit/70896ece02ea5ffbadd000b941850b13f9bc673e) Fix: add missing "const" and "fixed" modifiers to reflect API (#73) ### 📊 Changes **5 files changed** (+20 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/VmModifier.java` (+6 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input-helper/api/reflect/BaseModule.pkl` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/api/reflect1.pkl` (+5 -2) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/reflect1.pcf` (+4 -1) 📝 `stdlib/reflect.pkl` (+1 -1) </details> ### 📄 Description This fixes an issue where the reflect API does not show `fixed` or `const` modifiers on a property. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:54 +01:00
adam closed this issue 2025-12-30 01:24:54 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#485
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?