[PR #218] [MERGED] Improve code consistency with final modifier. #461

New Issue

adam · 2025-12-30T01:24:37+01:00

adam commented

2025-12-30 01:24:37 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/218
Author: @manuelsblanco
Created: 2/20/2024
Status: ✅ Merged
Merged: 2/21/2024
Merged by: @bioball

Base: main ← Head: may_have_final

📝 Commits (2)

4a114cb Improve code consistency with final modifier.
5cff3a1 Make fields private

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 pkl-config-java/src/main/java/org/pkl/config/java/InvalidMappingException.java (+2 -2)

📄 Description

Hi pkl team

I hope this message finds you well.

I've made some enhancements to the code in the InvalidMappingException class located at

pkl-config-java/src/main/java/org/pkl/config/java/InvalidMappingException.java.

The changes aim to improve code consistency by utilizing the final modifier for certain variables.

I would love to get involved in this new exciting language.

The best

Manuel

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/218 **Author:** [@manuelsblanco](https://github.com/manuelsblanco) **Created:** 2/20/2024 **Status:** ✅ Merged **Merged:** 2/21/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `may_have_final` --- ### 📝 Commits (2) - [`4a114cb`](https://github.com/apple/pkl/commit/4a114cbcc1f247408bef80068be8fc2c308eea51) Improve code consistency with final modifier. - [`5cff3a1`](https://github.com/apple/pkl/commit/5cff3a14c691cfc2d9b3fcbfaea78fc0bd8abe8a) Make fields private ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pkl-config-java/src/main/java/org/pkl/config/java/InvalidMappingException.java` (+2 -2) </details> ### 📄 Description Hi pkl team I hope this message finds you well. I've made some enhancements to the code in the InvalidMappingException class located at pkl-config-java/src/main/java/org/pkl/config/java/InvalidMappingException.java. The changes aim to improve code consistency by utilizing the final modifier for certain variables. I would love to get involved in this new exciting language. The best Manuel --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:24:37 +01:00

adam closed this issue

2025-12-30 01:24:37 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#461