starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #211] [MERGED] Move tool versions to Version Catalog #453

New Issue
Closed
opened 2025-12-30 01:24:34 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:34 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/211
Author: @sgammon
Created: 2/20/2024
Status: ✅ Merged
Merged: 2/21/2024
Merged by: @holzensp

Base: main ← Head: chore/tools-in-catalog

📝 Commits (1)

  • 8508af3 Move tool versions to Version Catalog

📊 Changes

4 files changed (+18 additions, -2 deletions)

View changed files

📝 buildSrc/build.gradle.kts (+4 -0)
📝 buildSrc/src/main/kotlin/pklJavaLibrary.gradle.kts (+6 -1)
📝 buildSrc/src/main/kotlin/pklKotlinLibrary.gradle.kts (+6 -1)
📝 gradle/libs.versions.toml (+2 -0)

📄 Description

Summary

Add a fix to make Version Catalog symbols visible within the buildSrc plugins, and then move tool versions (Google Java Format and ktfmt) into the catalog.

Originally previewed as part of apple/pkl#204.

Changelog

  • fix: make version catalog accessible from buildSrc plugins
  • chore: declare googleFormatVersion in version catalog
  • chore: declare ktfmt in version catalog

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/211 **Author:** [@sgammon](https://github.com/sgammon) **Created:** 2/20/2024 **Status:** ✅ Merged **Merged:** 2/21/2024 **Merged by:** [@holzensp](https://github.com/holzensp) **Base:** `main` ← **Head:** `chore/tools-in-catalog` --- ### 📝 Commits (1) - [`8508af3`](https://github.com/apple/pkl/commit/8508af3e4b59ef33755846032c02d7985f99dc2f) Move tool versions to Version Catalog ### 📊 Changes **4 files changed** (+18 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `buildSrc/build.gradle.kts` (+4 -0) 📝 `buildSrc/src/main/kotlin/pklJavaLibrary.gradle.kts` (+6 -1) 📝 `buildSrc/src/main/kotlin/pklKotlinLibrary.gradle.kts` (+6 -1) 📝 `gradle/libs.versions.toml` (+2 -0) </details> ### 📄 Description ## Summary Add a fix to make Version Catalog symbols visible within the `buildSrc` plugins, and then move tool versions (Google Java Format and ktfmt) into the catalog. Originally previewed as part of apple/pkl#204. ## Changelog - fix: make version catalog accessible from `buildSrc` plugins - chore: declare `googleFormatVersion` in version catalog - chore: declare `ktfmt` in version catalog --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:34 +01:00
adam closed this issue 2025-12-30 01:24:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#453
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?