[PR #194] [MERGED] Add codegen setting governing Kotlin package #444

New Issue

adam · 2025-12-30T01:24:31+01:00

adam commented

2025-12-30 01:24:31 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/194
Author: @sgammon
Created: 2/18/2024
Status: ✅ Merged
Merged: 2/23/2024
Merged by: @stackoverflow

Base: main ← Head: feat/issue-187

📝 Commits (1)

b28452c Add setting for Kotlin package to codegen

📊 Changes

7 files changed (+145 additions, -8 deletions)

View changed files

📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorOptions.kt (+10 -1)
📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/KotlinCodeGenerator.kt (+16 -3)
📝 pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/KotlinCodeGeneratorTest.kt (+90 -2)
📝 pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java (+3 -0)
📝 pkl-gradle/src/main/java/org/pkl/gradle/spec/KotlinCodeGenSpec.java (+4 -0)
📝 pkl-gradle/src/main/java/org/pkl/gradle/task/KotlinCodeGenTask.java (+4 -0)
📝 pkl-gradle/src/test/kotlin/org/pkl/gradle/KotlinCodeGeneratorsTest.kt (+18 -2)

📄 Description

Summary

Adds a setting to the Kotlin code generator which acts as a prefix for the target Kotlin package during codegen.

This has been filed on top of #192 to avoid conflicts.

Changelog

feat(gradle): kotlinPackage property in gradle plugin
feat(codegen): use kotlinPackage as prefix for kotlin codegen
fix: pin version of kotlinx.html and kotlinx.serialization
test(codegen): add tests for custom kotlin package
test(gradle): add tests for generating with custom kotlin package

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/194 **Author:** [@sgammon](https://github.com/sgammon) **Created:** 2/18/2024 **Status:** ✅ Merged **Merged:** 2/23/2024 **Merged by:** [@stackoverflow](https://github.com/stackoverflow) **Base:** `main` ← **Head:** `feat/issue-187` --- ### 📝 Commits (1) - [`b28452c`](https://github.com/apple/pkl/commit/b28452c8f9b05e3966aad4c2cebe17a53c6cc9db) Add setting for Kotlin package to codegen ### 📊 Changes **7 files changed** (+145 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorOptions.kt` (+10 -1) 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/KotlinCodeGenerator.kt` (+16 -3) 📝 `pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/KotlinCodeGeneratorTest.kt` (+90 -2) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java` (+3 -0) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/spec/KotlinCodeGenSpec.java` (+4 -0) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/task/KotlinCodeGenTask.java` (+4 -0) 📝 `pkl-gradle/src/test/kotlin/org/pkl/gradle/KotlinCodeGeneratorsTest.kt` (+18 -2) </details> ### 📄 Description ## Summary Adds a setting to the Kotlin code generator which acts as a prefix for the target Kotlin package during codegen. This has been filed on top of #192 to avoid conflicts. ## Changelog - feat(gradle): `kotlinPackage` property in gradle plugin - feat(codegen): use `kotlinPackage` as prefix for kotlin codegen - fix: pin version of `kotlinx.html` and `kotlinx.serialization` - test(codegen): add tests for custom kotlin package - test(gradle): add tests for generating with custom kotlin package --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:24:31 +01:00

adam closed this issue

2025-12-30 01:24:31 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#444