starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 15:13:38 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #192] [MERGED] Fix dropped implementSerializable flag #440

New Issue
Closed
opened 2025-12-30 01:24:29 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:29 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/192
Author: @sgammon
Created: 2/18/2024
Status: ✅ Merged
Merged: 2/22/2024
Merged by: @holzensp

Base: main ← Head: fix/issue-191

📝 Commits (1)

  • 13df959 Fix dropped implementSerializable flag

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorOptions.kt (+1 -1)

📄 Description

Fixes and closes apple/pkl#191:

In CliKotlinCodeGeneratorOptions, the implementSerializable property is not copied to the KotlinCodegenOptions, in effect meaning it cannot be toggled to true.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/192 **Author:** [@sgammon](https://github.com/sgammon) **Created:** 2/18/2024 **Status:** ✅ Merged **Merged:** 2/22/2024 **Merged by:** [@holzensp](https://github.com/holzensp) **Base:** `main` ← **Head:** `fix/issue-191` --- ### 📝 Commits (1) - [`13df959`](https://github.com/apple/pkl/commit/13df9591f2e3554df838e9f4e0b8ccc2d44b4c87) Fix dropped `implementSerializable` flag ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorOptions.kt` (+1 -1) </details> ### 📄 Description Fixes and closes apple/pkl#191: > In [CliKotlinCodeGeneratorOptions](https://github.com/apple/pkl/blob/3b2feb45cf47ef97c6db38b2cb5af4ecc713f447/pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorOptions.kt#L41-L42), the implementSerializable property is not copied to the KotlinCodegenOptions, in effect meaning it cannot be toggled to true. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:29 +01:00
adam closed this issue 2025-12-30 01:24:30 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#440
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?