starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-14 15:43:41 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #169] [MERGED] Rename some CLI classes for consistency #436

New Issue
Closed
opened 2025-12-30 01:24:28 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:28 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/169
Author: @odenix
Created: 2/16/2024
Status: ✅ Merged
Merged: 2/23/2024
Merged by: @bioball

Base: main ← Head: rename-classes

📝 Commits (1)

  • b8cc2a6 Rename some CLI classes for consistency

📊 Changes

6 files changed (+16 additions, -18 deletions)

View changed files

📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliPackageDownloader.kt (+1 -1)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliProjectCommand.kt (+2 -4)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliProjectPackager.kt (+1 -1)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliProjectResolver.kt (+1 -1)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/commands/DownloadPackageCommand.kt (+2 -2)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliPackageDownloaderTest.kt (+9 -9)

📄 Description

CliDownloadPackageCommand -> CliPackageDownloader (consistent with CliProjectPackager/CliProjectResolver) CliAbstractProjectCommand -> CliProjectCommand (consistent with CliCommand)

As I learned yesterday, I'm touching a public API here. Let me know if this is acceptable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/169 **Author:** [@odenix](https://github.com/odenix) **Created:** 2/16/2024 **Status:** ✅ Merged **Merged:** 2/23/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `rename-classes` --- ### 📝 Commits (1) - [`b8cc2a6`](https://github.com/apple/pkl/commit/b8cc2a62f877638009ac8f343bf7ab2f6cf67056) Rename some CLI classes for consistency ### 📊 Changes **6 files changed** (+16 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliPackageDownloader.kt` (+1 -1) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliProjectCommand.kt` (+2 -4) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliProjectPackager.kt` (+1 -1) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliProjectResolver.kt` (+1 -1) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/commands/DownloadPackageCommand.kt` (+2 -2) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliPackageDownloaderTest.kt` (+9 -9) </details> ### 📄 Description CliDownloadPackageCommand -> CliPackageDownloader (consistent with CliProjectPackager/CliProjectResolver) CliAbstractProjectCommand -> CliProjectCommand (consistent with CliCommand) As I learned yesterday, I'm touching a public API here. Let me know if this is acceptable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:28 +01:00
adam closed this issue 2025-12-30 01:24:28 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#436
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?