[PR #162] [MERGED] Fix typo in constructor parameter name #430

New Issue

adam · 2025-12-30T01:24:26+01:00

adam commented

2025-12-30 01:24:26 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/162
Author: @odenix
Created: 2/15/2024
Status: ✅ Merged
Merged: 2/15/2024
Merged by: @bioball

Base: main ← Head: fix-typo

📝 Commits (1)

94a9a52 Fix typo in constructor parameter name

📊 Changes

2 files changed (+10 additions, -10 deletions)

View changed files

📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliDownloadPackageCommand.kt (+2 -2)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliDownloadPackageCommandTest.kt (+8 -8)

📄 Description

This is a backwards-incompatible change. I assume this isn't a public API because it isn't documented.

PS: CliDownloadPackageCommandTest is very flaky for me. I believe the reason is that PackageServer binds to a hardcoded port (12110).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/162 **Author:** [@odenix](https://github.com/odenix) **Created:** 2/15/2024 **Status:** ✅ Merged **Merged:** 2/15/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-typo` --- ### 📝 Commits (1) - [`94a9a52`](https://github.com/apple/pkl/commit/94a9a5293c6f046e586abb5f49d9febf082742f7) Fix typo in constructor parameter name ### 📊 Changes **2 files changed** (+10 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliDownloadPackageCommand.kt` (+2 -2) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliDownloadPackageCommandTest.kt` (+8 -8) </details> ### 📄 Description This is a backwards-incompatible change. I assume this isn't a public API because it isn't documented. PS: `CliDownloadPackageCommandTest` is very flaky for me. I believe the reason is that `PackageServer` binds to a hardcoded port (12110). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:24:26 +01:00

adam closed this issue

2025-12-30 01:24:26 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#430