starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-09-03 08:17:14 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #120] [MERGED] Minor documentation fixes #418

New Issue
Closed
opened 2025-12-30 01:24:23 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:23 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/120
Author: @hoxell
Created: 2/11/2024
Status: ✅ Merged
Merged: 2/13/2024
Merged by: @holzensp

Base: main ← Head: doc/minor_doc_fixes

📝 Commits (4)

  • a5b7321 Pigeon -> dodo
  • b954545 Use object name instead of 'name' property
  • 0a3106d Fix mislabeled object name
  • 3370dbd Apply suggestions from code review

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 docs/modules/language-reference/pages/index.adoc (+1 -1)
📝 docs/modules/language-tutorial/pages/02_filling_out_a_template.adoc (+1 -1)

📄 Description

At docs/modules/language-tutorial/pages/02_filling_out_a_template.adoc:35, I guess it makes at least some sense to keep it as is (it was prettier before my change), but I believe the proposed change makes it ever so slightly more accurate, making it a tiny bit easier for first-time readers to understand the nomenclature.

(Absolutely love this tool btw! 😍)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/120 **Author:** [@hoxell](https://github.com/hoxell) **Created:** 2/11/2024 **Status:** ✅ Merged **Merged:** 2/13/2024 **Merged by:** [@holzensp](https://github.com/holzensp) **Base:** `main` ← **Head:** `doc/minor_doc_fixes` --- ### 📝 Commits (4) - [`a5b7321`](https://github.com/apple/pkl/commit/a5b73215d3ce904a98aae42751f644cec8b25d0c) Pigeon -> dodo - [`b954545`](https://github.com/apple/pkl/commit/b9545450bbf5e5a469d34bd81eff1d47aeceb74f) Use object name instead of 'name' property - [`0a3106d`](https://github.com/apple/pkl/commit/0a3106d8553ae580917a888cd42abcf297c3faa7) Fix mislabeled object name - [`3370dbd`](https://github.com/apple/pkl/commit/3370dbd81173fe44b57baed3b5860e2bb736ebc2) Apply suggestions from code review ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/language-reference/pages/index.adoc` (+1 -1) 📝 `docs/modules/language-tutorial/pages/02_filling_out_a_template.adoc` (+1 -1) </details> ### 📄 Description At docs/modules/language-tutorial/pages/02_filling_out_a_template.adoc:35, I guess it makes at least some sense to keep it as is (it was prettier before my change), but I believe the proposed change makes it ever so slightly more accurate, making it a tiny bit easier for first-time readers to understand the nomenclature. (Absolutely love this tool btw! 😍) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:23 +01:00
adam closed this issue 2025-12-30 01:24:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#418