starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 15:13:38 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #96] [MERGED] Fixes for pkldoc #411

New Issue
Closed
opened 2025-12-30 01:24:21 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/96
Author: @bioball
Created: 2/8/2024
Status: ✅ Merged
Merged: 2/8/2024
Merged by: @bioball

Base: main ← Head: pkldoc-fixes

📝 Commits (3)

📊 Changes

126 files changed (+3234 additions, -2560 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/util/IoUtils.java (+3 -3)
📝 pkl-core/src/test/kotlin/org/pkl/core/runtime/DefaultModuleResolverTest.kt (+1 -1)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/ClassPageGenerator.kt (+2 -2)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/DocGenerator.kt (+1 -2)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/DocPackageInfo.kt (+8 -4)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/DocScope.kt (+6 -6)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/MainOrPackagePageGenerator.kt (+5 -1)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/ModuleOrClassPageGenerator.kt (+2 -2)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/ModulePageGenerator.kt (+2 -2)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/PageGenerator.kt (+6 -6)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/Util.kt (+33 -0)
📝 pkl-doc/src/test/files/DocGeneratorTest/input/com.externalpackage/doc-package-info.pkl (+1 -1)
➕ pkl-doc/src/test/files/DocGeneratorTest/input/com.package1/Module Containing Spaces.pkl (+2 -0)
📝 pkl-doc/src/test/files/DocGeneratorTest/input/com.package1/doc-package-info.pkl (+1 -1)
➕ pkl-doc/src/test/files/DocGeneratorTest/input/com.package1/referenceToExternalPackage.pkl (+4 -0)
📝 pkl-doc/src/test/files/DocGeneratorTest/input/com.package2/Module3.pkl (+7 -0)
➕ pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/Module Containing Spaces/index.html (+196 -0)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/baseModule/BaseClass.html (+21 -21)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/baseModule/index.html (+28 -28)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/classAnnotations/AnnotatedClass.html (+21 -21)

...and 80 more files

📄 Description

  • Add URI encoding to paths and fragments
  • Render quotes around identifiers when appropriate

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/96 **Author:** [@bioball](https://github.com/bioball) **Created:** 2/8/2024 **Status:** ✅ Merged **Merged:** 2/8/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `pkldoc-fixes` --- ### 📝 Commits (3) - [`4ff6f77`](https://github.com/apple/pkl/commit/4ff6f7732daa998d243764b8ffbb89e544893bf0) Fixes for pkldoc - [`1f9f7d5`](https://github.com/apple/pkl/commit/1f9f7d5788b9abd14d662ac1f56614db22295ef0) XML escape anchor ids - [`34da973`](https://github.com/apple/pkl/commit/34da973284220551966b45cb283bcac3758eebe0) Re-do URI escaped anchor ids, add test ### 📊 Changes **126 files changed** (+3234 additions, -2560 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/util/IoUtils.java` (+3 -3) 📝 `pkl-core/src/test/kotlin/org/pkl/core/runtime/DefaultModuleResolverTest.kt` (+1 -1) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/ClassPageGenerator.kt` (+2 -2) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/DocGenerator.kt` (+1 -2) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/DocPackageInfo.kt` (+8 -4) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/DocScope.kt` (+6 -6) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/MainOrPackagePageGenerator.kt` (+5 -1) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/ModuleOrClassPageGenerator.kt` (+2 -2) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/ModulePageGenerator.kt` (+2 -2) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/PageGenerator.kt` (+6 -6) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/Util.kt` (+33 -0) 📝 `pkl-doc/src/test/files/DocGeneratorTest/input/com.externalpackage/doc-package-info.pkl` (+1 -1) ➕ `pkl-doc/src/test/files/DocGeneratorTest/input/com.package1/Module Containing Spaces.pkl` (+2 -0) 📝 `pkl-doc/src/test/files/DocGeneratorTest/input/com.package1/doc-package-info.pkl` (+1 -1) ➕ `pkl-doc/src/test/files/DocGeneratorTest/input/com.package1/referenceToExternalPackage.pkl` (+4 -0) 📝 `pkl-doc/src/test/files/DocGeneratorTest/input/com.package2/Module3.pkl` (+7 -0) ➕ `pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/Module Containing Spaces/index.html` (+196 -0) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/baseModule/BaseClass.html` (+21 -21) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/baseModule/index.html` (+28 -28) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/classAnnotations/AnnotatedClass.html` (+21 -21) _...and 80 more files_ </details> ### 📄 Description * Add URI encoding to paths and fragments * Render quotes around identifiers when appropriate --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:21 +01:00
adam closed this issue 2025-12-30 01:24:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#411
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?