starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #83] [MERGED] Only build static executable if musl toolchain is installed #402

New Issue
Closed
opened 2025-12-30 01:24:18 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:18 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/83
Author: @odenix
Created: 2/7/2024
Status: ✅ Merged
Merged: 2/8/2024
Merged by: @bioball

Base: main ← Head: check-musl

📝 Commits (2)

  • a5fbbde Only build static executable if musl toolchain is installed
  • 3bccd21 Update BuildInfo.kt

📊 Changes

3 files changed (+7 additions, -2 deletions)

View changed files

📝 buildSrc/src/main/kotlin/BuildInfo.kt (+5 -0)
📝 pkl-cli/pkl-cli.gradle.kts (+1 -1)
📝 pkl-core/pkl-core.gradle.kts (+1 -1)

📄 Description

This improves the development experience for (WSL) Linux users. They can now run "./gradlew buildNative" without having a musl toolchain installed. In this case, only the dynamically linked executable will be built.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/83 **Author:** [@odenix](https://github.com/odenix) **Created:** 2/7/2024 **Status:** ✅ Merged **Merged:** 2/8/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `check-musl` --- ### 📝 Commits (2) - [`a5fbbde`](https://github.com/apple/pkl/commit/a5fbbdec2912ee4233d7e34a291e3cc28aaf2870) Only build static executable if musl toolchain is installed - [`3bccd21`](https://github.com/apple/pkl/commit/3bccd214236af97c9290476a1b0d90cc6ecff0f9) Update BuildInfo.kt ### 📊 Changes **3 files changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `buildSrc/src/main/kotlin/BuildInfo.kt` (+5 -0) 📝 `pkl-cli/pkl-cli.gradle.kts` (+1 -1) 📝 `pkl-core/pkl-core.gradle.kts` (+1 -1) </details> ### 📄 Description This improves the development experience for (WSL) Linux users. They can now run "./gradlew buildNative" without having a musl toolchain installed. In this case, only the dynamically linked executable will be built. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:18 +01:00
adam closed this issue 2025-12-30 01:24:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#402
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?