starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 23:23:37 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #70] [MERGED] Fix broken search on pkldoc #394

New Issue
Closed
opened 2025-12-30 01:24:13 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:13 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/70
Author: @bioball
Created: 2/6/2024
Status: ✅ Merged
Merged: 2/6/2024
Merged by: @holzensp

Base: main ← Head: pkldoc-search-fix

📝 Commits (1)

  • df283f2 Fix broken search on pkldoc

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 pkl-doc/src/main/resources/org/pkl/doc/scripts/search-worker.js (+3 -3)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/scripts/search-worker.js (+3 -3)

📄 Description

Fixes two issues:

  1. The search-index.js script doesn't get imported in the docsite
  2. The regexes aren't accessible to the function, thanks to hoisting

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/70 **Author:** [@bioball](https://github.com/bioball) **Created:** 2/6/2024 **Status:** ✅ Merged **Merged:** 2/6/2024 **Merged by:** [@holzensp](https://github.com/holzensp) **Base:** `main` ← **Head:** `pkldoc-search-fix` --- ### 📝 Commits (1) - [`df283f2`](https://github.com/apple/pkl/commit/df283f2624a24d4cb52db6072193f26c5e657ed9) Fix broken search on pkldoc ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `pkl-doc/src/main/resources/org/pkl/doc/scripts/search-worker.js` (+3 -3) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/scripts/search-worker.js` (+3 -3) </details> ### 📄 Description Fixes two issues: 1. The search-index.js script doesn't get imported in the docsite 2. The regexes aren't accessible to the function, thanks to hoisting --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:13 +01:00
adam closed this issue 2025-12-30 01:24:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#394
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?