starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #54] [CLOSED] Use the KOTLIN_OFFICIAL code style defaults for Kotlin #385

New Issue
Closed
opened 2025-12-30 01:24:10 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:10 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/54
Author: @KushalP
Created: 2/5/2024
Status: ❌ Closed

Base: main ← Head: kotlin-style-guide-default

📝 Commits (2)

  • 947f24c Use the KOTLIN_OFFICIAL code style defaults for Kotlin
  • 6700018 Run spotlessApply with new .kotlinlangStyle() in use

📊 Changes

124 files changed (+15010 additions, -14478 deletions)

View changed files

📝 .idea/codeStyles/Project.xml (+6 -2)
📝 buildSrc/src/main/kotlin/pklKotlinLibrary.gradle.kts (+1 -1)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliAbstractProjectCommand.kt (+18 -18)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliDownloadPackageCommand.kt (+30 -30)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt (+176 -170)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluatorOptions.kt (+57 -56)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliProjectPackager.kt (+59 -55)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliProjectResolver.kt (+27 -24)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliRepl.kt (+43 -43)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliServer.kt (+7 -7)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliTestRunner.kt (+57 -57)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/Main.kt (+26 -26)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/commands/DownloadPackageCommand.kt (+27 -27)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/commands/EvalCommand.kt (+57 -55)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/commands/ProjectCommand.kt (+63 -60)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/commands/ReplCommand.kt (+11 -10)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/commands/RootCommand.kt (+14 -14)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/commands/ServerCommand.kt (+8 -8)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/commands/TestCommand.kt (+14 -14)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/repl/Repl.kt (+170 -170)

...and 80 more files

📄 Description

JetBrains both ships the language and an editor for Kotlin. We should conform to their house style where it makes sense to us.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/54 **Author:** [@KushalP](https://github.com/KushalP) **Created:** 2/5/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `kotlin-style-guide-default` --- ### 📝 Commits (2) - [`947f24c`](https://github.com/apple/pkl/commit/947f24cbad7104dc95e39bfd08fa645a803d9581) Use the `KOTLIN_OFFICIAL` code style defaults for Kotlin - [`6700018`](https://github.com/apple/pkl/commit/67000184f6c19d90f4aef16864cb0244f5e8c094) Run `spotlessApply` with new `.kotlinlangStyle()` in use ### 📊 Changes **124 files changed** (+15010 additions, -14478 deletions) <details> <summary>View changed files</summary> 📝 `.idea/codeStyles/Project.xml` (+6 -2) 📝 `buildSrc/src/main/kotlin/pklKotlinLibrary.gradle.kts` (+1 -1) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliAbstractProjectCommand.kt` (+18 -18) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliDownloadPackageCommand.kt` (+30 -30) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt` (+176 -170) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluatorOptions.kt` (+57 -56) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliProjectPackager.kt` (+59 -55) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliProjectResolver.kt` (+27 -24) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliRepl.kt` (+43 -43) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliServer.kt` (+7 -7) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliTestRunner.kt` (+57 -57) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/Main.kt` (+26 -26) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/commands/DownloadPackageCommand.kt` (+27 -27) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/commands/EvalCommand.kt` (+57 -55) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/commands/ProjectCommand.kt` (+63 -60) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/commands/ReplCommand.kt` (+11 -10) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/commands/RootCommand.kt` (+14 -14) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/commands/ServerCommand.kt` (+8 -8) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/commands/TestCommand.kt` (+14 -14) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/repl/Repl.kt` (+170 -170) _...and 80 more files_ </details> ### 📄 Description JetBrains both ships the language and an editor for Kotlin. We should conform to their house style where it makes sense to us. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:10 +01:00
adam closed this issue 2025-12-30 01:24:10 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#385
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?