starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-08-09 21:58:41 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

codegen-java: Support generating record classes #247

New Issue
Open
opened 2025-12-30 01:22:40 +01:00 by adam · 4 comments
adam commented 2025-12-30 01:22:40 +01:00
Owner
Copy Link
Copy Source

Originally created by @odenix on GitHub (Nov 12, 2024).

codegen-java should support generating record classes instead of regular classes whenever possible.
(codegen-kotlin already generates data classes whenever possible.)

I have this almost working, but one important question remains: how to deal with backward compatibility?

One option is to introduce a —generate-records flag and only generate record classes if this flag is set.
Another option is to ask users to stay on the 0.27 code generator until they are ready to switch to record classes.
In any case, generating record classes should eventually become the default.

Originally created by @odenix on GitHub (Nov 12, 2024). codegen-java should support generating record classes instead of regular classes whenever possible. (codegen-kotlin already generates data classes whenever possible.) I have this almost working, but one important question remains: how to deal with backward compatibility? One option is to introduce a `—generate-records` flag and only generate record classes if this flag is set. Another option is to ask users to stay on the 0.27 code generator until they are ready to switch to record classes. In any case, generating record classes should eventually become the default.
adam added the enhancement label 2025-12-30 01:22:40 +01:00
adam commented 2025-12-30 01:22:42 +01:00
Author
Owner
Copy Link
Copy Source

@bioball commented on GitHub (Nov 13, 2024):

Yeah, definitely. Now with Java 11 dropped, the code generator should generate records. I think this is okay as a breaking change (generate java records by default, require flag to retain old behavior).

@bioball commented on GitHub (Nov 13, 2024): Yeah, definitely. Now with Java 11 dropped, the code generator should generate records. I think this is okay as a breaking change (generate java records by default, require flag to retain old behavior).
adam commented 2025-12-30 01:22:43 +01:00
Author
Owner
Copy Link
Copy Source

@odenix commented on GitHub (Nov 19, 2024):

Blocked on #790.

@odenix commented on GitHub (Nov 19, 2024): Blocked on #790.
adam commented 2025-12-30 01:22:43 +01:00
Author
Owner
Copy Link
Copy Source

@raymyers commented on GitHub (Jan 10, 2025):

Blocked on #790.

So that might mean unblocked now then? 🤞

@raymyers commented on GitHub (Jan 10, 2025): > Blocked on #790. So that might mean unblocked now then? 🤞
adam commented 2025-12-30 01:22:44 +01:00
Author
Owner
Copy Link
Copy Source

@bioball commented on GitHub (Mar 1, 2025):

Implementation: https://github.com/apple/pkl/pull/970

@bioball commented on GitHub (Mar 1, 2025): Implementation: https://github.com/apple/pkl/pull/970
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#247