starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-09-03 08:27:25 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Snippet test invalidGlobImport6.pkl is too slow #214

New Issue
Closed
opened 2025-12-30 01:22:19 +01:00 by adam · 5 comments
adam commented 2025-12-30 01:22:19 +01:00
Owner
Copy Link
Copy Source

Originally created by @odenix on GitHub (Oct 15, 2024).

This test takes 15 seconds to run on my machine, hampering developer productivity.

Originally created by @odenix on GitHub (Oct 15, 2024). This test takes 15 seconds to run on my machine, hampering developer productivity.
adam closed this issue 2025-12-30 01:22:19 +01:00
adam commented 2025-12-30 01:22:20 +01:00
Author
Owner
Copy Link
Copy Source

@bioball commented on GitHub (Oct 15, 2024):

Typically, I only include the tests that address the issue I'm working on by adding a filter here: https://github.com/apple/pkl/blob/d00c466843abf1d88abf9d897941fce71334efd4/pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt#L53

But, if you really want to exclude this test specifically, you can also add it to your excluded tests temporarily:

diff --git a/pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt b/pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt
index 1aca859ab..061ecf81c 100644
--- a/pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt
+++ b/pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt
@@ -58,6 +58,7 @@ abstract class AbstractLanguageSnippetTestsEngine : InputOutputTestEngine() {
 
   override val excludedTests: List<Regex> = buildList {
     add(Regex(".*/native/.*"))
+    add(Regex(".*/invalidGlobImport6\\.pkl"))
     if (IoUtils.isWindows()) {
       addAll(windowsExcludedTests)
     }
@bioball commented on GitHub (Oct 15, 2024): Typically, I only include the tests that address the issue I'm working on by adding a filter here: https://github.com/apple/pkl/blob/d00c466843abf1d88abf9d897941fce71334efd4/pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt#L53 But, if you really want to exclude this test specifically, you can also add it to your excluded tests temporarily: ```diff diff --git a/pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt b/pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt index 1aca859ab..061ecf81c 100644 --- a/pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt +++ b/pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt @@ -58,6 +58,7 @@ abstract class AbstractLanguageSnippetTestsEngine : InputOutputTestEngine() { override val excludedTests: List<Regex> = buildList { add(Regex(".*/native/.*")) + add(Regex(".*/invalidGlobImport6\\.pkl")) if (IoUtils.isWindows()) { addAll(windowsExcludedTests) } ```
adam commented 2025-12-30 01:22:20 +01:00
Author
Owner
Copy Link
Copy Source

@odenix commented on GitHub (Oct 15, 2024):

My point is that this test slows down ./gradlew test by 15 seconds, which isn't justified.

A common solution for testing the enforcement of a limit is to make the limit configurable and set a lower limit for the test.

@odenix commented on GitHub (Oct 15, 2024): My point is that this test slows down `./gradlew test` by 15 seconds, which isn't justified. A common solution for testing the enforcement of a limit is to make the limit configurable and set a lower limit for the test.
adam commented 2025-12-30 01:22:20 +01:00
Author
Owner
Copy Link
Copy Source

@bioball commented on GitHub (Oct 15, 2024):

That sounds like a good solution to this problem

@bioball commented on GitHub (Oct 15, 2024): That sounds like a good solution to this problem
adam commented 2025-12-30 01:22:21 +01:00
Author
Owner
Copy Link
Copy Source

@odenix commented on GitHub (Oct 15, 2024):

Would you be OK with making this limit configurable in the CLI and Evaluator API?

PS: Is a Pkl release imminent, or was it postponed?

@odenix commented on GitHub (Oct 15, 2024): Would you be OK with making this limit configurable in the CLI and Evaluator API? PS: Is a Pkl release imminent, or was it postponed?
adam commented 2025-12-30 01:22:21 +01:00
Author
Owner
Copy Link
Copy Source

@bioball commented on GitHub (Oct 16, 2024):

It's imminent! We're targeting an end-of-October release, so, in the next two weeks.

I'd rather not add user-facing knobs here. I think this can be as simple as something like this in GlobResolver:

-private static final int MAX_LIST_ELEMENTS = 16384;
+private static final int MAX_LIST_ELEMENTS = IoUtils.isTestMode() ? 500 : 16384;
@bioball commented on GitHub (Oct 16, 2024): It's imminent! We're targeting an end-of-October release, so, in the next two weeks. I'd rather not add user-facing knobs here. I think this can be as simple as something like this in `GlobResolver`: ```diff -private static final int MAX_LIST_ELEMENTS = 16384; +private static final int MAX_LIST_ELEMENTS = IoUtils.isTestMode() ? 500 : 16384; ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#214