starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-08-12 06:52:02 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Support Go semver convention #197

New Issue
Closed
opened 2025-12-30 01:22:02 +01:00 by adam · 2 comments
adam commented 2025-12-30 01:22:02 +01:00
Owner
Copy Link
Copy Source

Originally created by @jjuliano on GitHub (Aug 10, 2024).

When running go mod tidy, the version must be prefixed with a 'v'. However, the file at https://github.com/apple/pkl/blob/0.25.2/stdlib/Project.pkl#L276 expects the version without the 'v'. Since I've placed the generated Go files in a separate repository, the default behavior of go mod tidy will fail to locate the package if the version is not prefixed with the 'v'.

Originally created by @jjuliano on GitHub (Aug 10, 2024). When running `go mod tidy`, the version must be prefixed with a 'v'. However, the file at https://github.com/apple/pkl/blob/0.25.2/stdlib/Project.pkl#L276 expects the version without the 'v'. Since I've placed the generated Go files in a separate repository, the default behavior of `go mod tidy` will fail to locate the package if the version is not prefixed with the 'v'.
adam closed this issue 2025-12-30 01:22:02 +01:00
adam commented 2025-12-30 01:22:03 +01:00
Author
Owner
Copy Link
Copy Source

@jjuliano commented on GitHub (Aug 10, 2024):

I have resolved it by defining a regexp on the PklProject

version =  read?("env:VERSION").replaceFirst(Regex("^v(\\d+\\.\\d+\\.\\d+)(-[\\w\\.]+)?(\\+[\\w\\.]+)?$"), "$1")
@jjuliano commented on GitHub (Aug 10, 2024): I have resolved it by defining a regexp on the PklProject ``` version = read?("env:VERSION").replaceFirst(Regex("^v(\\d+\\.\\d+\\.\\d+)(-[\\w\\.]+)?(\\+[\\w\\.]+)?$"), "$1") ```
adam commented 2025-12-30 01:22:03 +01:00
Author
Owner
Copy Link
Copy Source

@bioball commented on GitHub (Sep 6, 2024):

I don't think we will support a leading v, because that leads to ambiguous situations (what do you do if there is both v1.0.0 and 1.0.0?)

Your workaround seems like a good solution!

@bioball commented on GitHub (Sep 6, 2024): I don't think we will support a leading `v`, because that leads to ambiguous situations (what do you do if there is both v1.0.0 and 1.0.0?) Your workaround seems like a good solution!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#197