Originally created by @odenix on GitHub (Apr 30, 2024).
Unsquashed PRs with poor commit messages keep appearing on the main branch. To prevent such oversights in the future, I propose to disable "Allow merge commits" and "Allow rebase merging" in GitHub settings. Note that this only affects the GitHub UI.
Originally created by @odenix on GitHub (Apr 30, 2024).
Unsquashed PRs with poor commit messages keep appearing on the main branch. To prevent such oversights in the future, I propose to disable "Allow merge commits" and "Allow rebase merging" in GitHub settings. Note that this only affects the GitHub UI.
How would we rebase-merge if it's disabled in the UI? Would gh work if we intentionally wanted to rebase-merge?
@bioball commented on GitHub (Apr 30, 2024):
How would we rebase-merge if it's disabled in the UI? Would `gh` work if we intentionally wanted to rebase-merge?
Correction: gh pr merge does honor these settings. So you'd need to use plain git to intentionally do a rebase-merge.
@odenix commented on GitHub (May 4, 2024):
Correction: `gh pr merge` does honor these settings. So you'd need to use plain git to intentionally do a rebase-merge.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @odenix on GitHub (Apr 30, 2024).
Unsquashed PRs with poor commit messages keep appearing on the main branch. To prevent such oversights in the future, I propose to disable "Allow merge commits" and "Allow rebase merging" in GitHub settings. Note that this only affects the GitHub UI.
@bioball commented on GitHub (Apr 30, 2024):
How would we rebase-merge if it's disabled in the UI? Would
ghwork if we intentionally wanted to rebase-merge?@odenix commented on GitHub (Apr 30, 2024):
I haven't tried, but I'd expect gh to be unaffected. Plain git is definitely unaffected.
@odenix commented on GitHub (May 4, 2024):
Correction:
gh pr mergedoes honor these settings. So you'd need to use plain git to intentionally do a rebase-merge.