mirror of
https://github.com/apple/pkl.git
synced 2026-01-12 06:40:42 +01:00
Bug: fatal error when chart location is invalid #146
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MarkSRobinson on GitHub (Apr 15, 2024).
Command:
Version:
PklPackage:
PklProject.txt
(I had to rename it because of Github file filters)
Error:
Expected output:
@odenix commented on GitHub (Apr 15, 2024):
I’ve seen similar errors before. I think the root cause is that
CliProjectPackager.doRundoesn’t handle exceptions thrown byProjectPackager.createPackages.@eli-l commented on GitHub (Apr 16, 2024):
In case someone is looking for a solution to build a package w/o triggering exception:
pkl project package --skip-publish-check@holzensp commented on GitHub (Apr 16, 2024):
It certainly is a bug that the exception isn't handled, but the exception itself is correct, so I advise against
--skip-publish-check. Pkl checks whether you're not publishing a package with an existing version number. Conflicting versions will give you a very bad time.@eli-l commented on GitHub (Apr 16, 2024):
Thank you for highlighting it, however I found out it is the only way for now to actually build the package w/o valid URL if I am going to use it locally. I expect it uses
packageZipUrlwhich could not be a local file/dir. Definitely not a production-level solution, but we need a way to make it work to learn & experiment.@MarkSRobinson commented on GitHub (Apr 22, 2024):
@holzensp I've written up a small fix that improves the error message
@harryjackson commented on GitHub (Apr 24, 2024):
I just ran into this issue
Even though the stack trace looks like everything failed the package files were still created in the ".out/" directory ie
@holzensp commented on GitHub (Apr 25, 2024):
I let that review sit for a day; few tweaks, but certainly useful, @MarkSRobinson!
@harryjackson, is the zip 0 bytes? Is
pkl-project@0.0.1the only dependency?