mirror of
https://github.com/apple/pkl.git
synced 2026-01-11 22:30:54 +01:00
support ANSI color output of pkl eval
#142
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jstrachan on GitHub (Apr 12, 2024).
I was watching Viktor's review of pkl and the lack of syntax highlighting shouted me when running
pkl evalon the command line.I'm so used to color based syntax highlighting in all languages it really shouts to me when there's no color
I wonder if we should have an optional colour option to
pkl evalthat could use ANSI colours to make the output look nicer?@bioball commented on GitHub (Apr 12, 2024):
I use bat whenever I need better syntax highlighting in my output. E.g.
pkl eval foo.pkl | bat -l yaml.The
--formatflag can be ignored by a Pkl program by setting it directly in the module, so it's not really clear how we can add proper syntax highlighting here.It'd be good to colorize the output in case of errors, though.
@odenix commented on GitHub (Apr 12, 2024):
Would it be possible to support pluggable highlighters that are told which renderer is used?
@bioball commented on GitHub (Apr 12, 2024):
Might be doable to have the renderers themselves add ANSI escape sequences.
Would need to somehow know whether the CLI command is being run in interactive mode or not.
Generally CLI commands should strip colors if run in a non-interactive context (e.g.
pkl eval foo.pkl > output.yamlshould not include ANSI escape codes). And it's common to have a--colorflag that overrides the default behavior (e.g.--color=alwaysto keep color regardless of interactive mode).